You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by se...@apache.org on 2018/07/06 22:25:54 UTC
[whimsy] branch master updated: Error message sometimes scrolls off
top of screen
This is an automated email from the ASF dual-hosted git repository.
sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git
The following commit(s) were added to refs/heads/master by this push:
new 100a664 Error message sometimes scrolls off top of screen
100a664 is described below
commit 100a664cc45d1a8a970b332ee6716938d64c0232
Author: Sebb <se...@apache.org>
AuthorDate: Fri Jul 6 23:25:53 2018 +0100
Error message sometimes scrolls off top of screen
---
www/project/icla/views/pages/form.js.rb | 25 +++++++++++++------------
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/www/project/icla/views/pages/form.js.rb b/www/project/icla/views/pages/form.js.rb
index 4298039..cf1d7ba 100644
--- a/www/project/icla/views/pages/form.js.rb
+++ b/www/project/icla/views/pages/form.js.rb
@@ -12,18 +12,11 @@ class Form < Vue
end
def render
- # error messages / welcome
- if @alert
- _div.alert.alert_danger do
- _b 'Error: '
- _span @alert
- end
- else
- _p %{
- Thanks! Now please take a moment to answer a few questions about
- yourself.
- }
- end
+
+ _p %{
+ Thanks! Now please take a moment to answer a few questions about
+ yourself.
+ }
#
# Form fields
@@ -66,6 +59,14 @@ class Form < Vue
end
end
+ # needs to be near the button or it can scroll off the visible screen
+ if @alert
+ _div.alert.alert_danger do
+ _b 'Error: '
+ _span @alert
+ end
+ end
+
#
# Submit button
#