You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "TakaHiR07 (via GitHub)" <gi...@apache.org> on 2023/05/25 12:43:22 UTC
[GitHub] [bookkeeper] TakaHiR07 opened a new issue, #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger
TakaHiR07 opened a new issue, #3971:
URL: https://github.com/apache/bookkeeper/issues/3971
**BUG REPORT**
I also do a disaster recovery test, and try to use this feature to repair ledger. https://github.com/apache/bookkeeper/pull/3359
But it can not repair the ledger of pulsar "__change_event_" topic, because its ledger is opened status.
***Expected behavior***
Now my solution is also repair the opened ledger, and ensure not write the opened ledger by do not modify the topic metadata.
But I wonder if there have better way ?
By the way, now we can not repair not adhering RegionAware placement ledger. Can we add a config minNumRegionsPerWriteQuorum, just as minNumRacksPerWriteQuorum, to ensure quorum must be distributed in at least 3 regions ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on issue #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on issue #3971:
URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1567973815
> @horizonzy Please help take a look, thanks.
Fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on issue #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on issue #3971:
URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1568449729
> > Could you please tell me how you implemented it? Now we check the ledger placement policy when its metadata is closed. Did you change the source code to implement it?
> > https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260
>
> I change two part of source code, remove "if (!metadata.isClosed())"
>
> https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260
>
> https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java#L391
Make sense. There is one thing need to pay attention: the last ensemble should not be checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] TakaHiR07 commented on issue #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger
Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 commented on issue #3971:
URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1568016598
> > Now my solution is also repair the opened ledger, and ensure not write the opened ledger by do not modify the topic metadata.
>
> Could you please tell me how you implemented it? Now we check the ledger placement policy when its metadata is closed. Did you change the source code to implement it?
>
> https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260
I change two part of source code, remove "if (!metadata.isClosed())"
https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260
https://github.com/lordcheng10/bookkeeper/blob/8309b1895c240a7fba8719cacf551b2cc4abda42/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java#L391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on issue #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on issue #3971:
URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1573488822
> By the way, now we can not repair not adhering RegionAware placement ledger. Can we add a config minNumRegionsPerWriteQuorum, just as minNumRacksPerWriteQuorum, to ensure quorum must be distributed in at least 3 regions ?
And for this part, we didn't have a strong demand for it. If you need this feature, you can refer the org.apache.bookkeeper.client.RackawareEnsemblePlacementPolicyImpl#replaceToAdherePlacementPolicy to implement it in the RegionAwareEnsemblePlacementPolicy. I can help you to review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on issue #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 commented on issue #3971:
URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1567968569
@horizonzy Please help take a look, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on issue #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on issue #3971:
URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1572983133
> I change two part of source code, remove "if (!metadata.isClosed())"
>
> https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260
>
> https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java#L391
Could you please submit a PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] TakaHiR07 commented on issue #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger
Posted by "TakaHiR07 (via GitHub)" <gi...@apache.org>.
TakaHiR07 commented on issue #3971:
URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1573019019
> Could you please submit a PR?
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] horizonzy commented on issue #3971: [Bug] repaired not adhering placement ledger feature can not repair opened ledger
Posted by "horizonzy (via GitHub)" <gi...@apache.org>.
horizonzy commented on issue #3971:
URL: https://github.com/apache/bookkeeper/issues/3971#issuecomment-1567998089
> Now my solution is also repair the opened ledger, and ensure not write the opened ledger by do not modify the topic metadata.
Could you please tell me how you implemented it? Now we check the ledger placement policy when its metadata is closed. Did you change the source code to implement it?
https://github.com/apache/bookkeeper/blob/575a81c79e90e256e919287ef9762bc14d15789a/bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/AuditorPlacementPolicyCheckTask.java#L260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org