You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Erik Hatcher (JIRA)" <ji...@apache.org> on 2009/02/19 22:08:01 UTC

[jira] Created: (SOLR-1026) SnowballPorterFilterFactory does not support protected words

SnowballPorterFilterFactory does not support protected words
------------------------------------------------------------

                 Key: SOLR-1026
                 URL: https://issues.apache.org/jira/browse/SOLR-1026
             Project: Solr
          Issue Type: Bug
          Components: Analysis
    Affects Versions: 1.3
            Reporter: Erik Hatcher
            Assignee: Erik Hatcher
             Fix For: 1.4




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1026) SnowballPorterFilterFactory does not support protected words

Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675139#action_12675139 ] 

Erik Hatcher commented on SOLR-1026:
------------------------------------

With this, is there any reason to keep EnglishPorterFilterFactory?   SnowballPorterFilterFactory with langauge="English" is the same thing, right?   Maybe we deprecate EPFF?  Objections?  Is the reflection thing an issue?  The SnowballProgram is created in #create.

> SnowballPorterFilterFactory does not support protected words
> ------------------------------------------------------------
>
>                 Key: SOLR-1026
>                 URL: https://issues.apache.org/jira/browse/SOLR-1026
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 1.3
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>             Fix For: 1.4
>
>         Attachments: SOLR-1026.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-1026) SnowballPorterFilterFactory does not support protected words

Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik Hatcher resolved SOLR-1026.
--------------------------------

    Resolution: Fixed

> SnowballPorterFilterFactory does not support protected words
> ------------------------------------------------------------
>
>                 Key: SOLR-1026
>                 URL: https://issues.apache.org/jira/browse/SOLR-1026
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 1.3
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>             Fix For: 1.4
>
>         Attachments: SOLR-1026.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-1026) SnowballPorterFilterFactory does not support protected words

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12675146#action_12675146 ] 

Yonik Seeley commented on SOLR-1026:
------------------------------------

The reflection used to be much worse because it was invoked per token. That's been fixed, so now it's just Class.newInstance() per filter creation which shouldn't be as big of a deal.

> SnowballPorterFilterFactory does not support protected words
> ------------------------------------------------------------
>
>                 Key: SOLR-1026
>                 URL: https://issues.apache.org/jira/browse/SOLR-1026
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 1.3
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>             Fix For: 1.4
>
>         Attachments: SOLR-1026.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1026) SnowballPorterFilterFactory does not support protected words

Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik Hatcher updated SOLR-1026:
-------------------------------

    Attachment: SOLR-1026.patch

Copy/paste fix for the issue from EnglishPorterFilterFactory.

Better would be to put some base protected word infrastructure in place that other filters could leverage, but this works for now, and isn't all that horrible :)

> SnowballPorterFilterFactory does not support protected words
> ------------------------------------------------------------
>
>                 Key: SOLR-1026
>                 URL: https://issues.apache.org/jira/browse/SOLR-1026
>             Project: Solr
>          Issue Type: Bug
>          Components: Analysis
>    Affects Versions: 1.3
>            Reporter: Erik Hatcher
>            Assignee: Erik Hatcher
>             Fix For: 1.4
>
>         Attachments: SOLR-1026.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.