[GitHub] [trafficcontrol] jrushford commented on a change in pull request #5900: Define %{el8}/%{el7}/%{el6} macro according to RHEL_VERSION

[GitBox <gi...@apache.org>]

jrushford commented on a change in pull request #5900:
URL: https://github.com/apache/trafficcontrol/pull/5900#discussion_r645016203



##########
File path: cache-config/build/trafficcontrol-cache-config.spec
##########
@@ -26,10 +26,15 @@ Source0:  trafficcontrol-cache-config-%{version}.tgz
 URL:      https://github.com/apache/trafficcontrol/
 Vendor:   Apache Software Foundation
 Packager: dev at trafficcontrol dot Apache dot org
-%{?el6:Requires: git, perl}
-%{?el7:Requires: git, perl}
-%{?el8:Requires: git, perl}
-
+%if 0%{?el6}
+Requires: git, perl
+%elif 0%{?el7}
+Requires: git, perl
+%elif 0%{?el8}
+Requires: git, perl
+%else
+Requires: git, perl
+%endif

Review comment:
       @zrhoffman why not just drop lines lines 29 through 37 and just have **Requires: git, perl**?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org