[GitHub] [couchdb] pgj opened a new pull request, #4610: fix(mango): integration tests

["pgj (via GitHub)" <gi...@apache.org>]

pgj opened a new pull request, #4610:
URL: https://github.com/apache/couchdb/pull/4610

   - Fix the faulty `index_array_length` tests:
   
       - They do not check the count of the returned documents but blindly
         assume that there will be results.  Add an explicit assertion about
         the expected number of documents in the response so it could be
         detected if something breaks.
   
       - The assertion on the document count revealed that the test database
         is actually empty because it is immediately wiped out after creation
         by a misplaced `recreate()` call.
   
       - When the indexing on the array lengths is disabled, there shall be no
         documents returned, and not the sizes of the `favorites` arrays in
         the results shall be zero.  That is because there is no information
         available on the sizes of the arrays.
   
   - The result of the `mango.has_text_service()` checks is implicitly forecasted by the `@unittest.skipUnless` annotations in the head of the class declaration.  Hence they are not needed anymore.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] jaydoane merged pull request #4610: fix(mango): integration tests

["jaydoane (via GitHub)" <gi...@apache.org>]

jaydoane merged PR #4610:
URL: https://github.com/apache/couchdb/pull/4610


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org