[GitHub] [parquet-mr] prakharjain09 edited a comment on pull request #945: PARQUET-2117: Expose Row Index via ParquetReader and ParquetRecordReader

[GitBox <gi...@apache.org>]

prakharjain09 edited a comment on pull request #945:
URL: https://github.com/apache/parquet-mr/pull/945#issuecomment-1041089205


   @shangxinli Thanks fa lot or the review. I have addressed most of the comments.
   
   > [](https://github.com/prakharjain09)We need more test to cover old parquet data that doesn't have column index.
   
   I couldn't find any existing tests or any existing parquet files in Resource directory which doesn't have column indexes. Could you please give some pointer to similar existing test or some way to create parquet file without column indexes (don't see any options to disable writing column indexes either)?
   I have added tests for validating row indexes are correct with "column index filtering" disabled.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org