You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/04/06 10:05:23 UTC

[GitHub] ivankelly commented on a change in pull request #1318: MockLedgerHandle duplicates LedgerEntries on read

ivankelly commented on a change in pull request #1318: MockLedgerHandle duplicates LedgerEntries on read
URL: https://github.com/apache/bookkeeper/pull/1318#discussion_r179713484
 
 

 ##########
 File path: bookkeeper-server/src/test/java/org/apache/bookkeeper/client/MockLedgerHandle.java
 ##########
 @@ -108,7 +108,7 @@ public void run() {
                 final Queue<LedgerEntry> seq = new ArrayDeque<LedgerEntry>();
                 long entryId = firstEntry;
                 while (entryId <= lastEntry && entryId < entries.size()) {
-                    seq.add(new LedgerEntry(entries.get((int) entryId++)));
+                    seq.add(new LedgerEntry(entries.get((int) entryId++).duplicate()));
 
 Review comment:
   Already merged. If I'm in the area again, ill change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services