You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by uce <gi...@git.apache.org> on 2017/02/23 12:31:00 UTC

[GitHub] flink pull request #3401: [FLINK-5894] [docs] Fix misleading HA docs

GitHub user uce opened a pull request:

    https://github.com/apache/flink/pull/3401

    [FLINK-5894] [docs] Fix misleading HA docs

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/uce/flink 5894-ha_docs

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3401.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3401
    
----
commit fa534a2a1f33a7d0d5d3665f90ea14cfff216557
Author: Ufuk Celebi <uc...@apache.org>
Date:   2017-02-23T12:30:13Z

    [FLINK-5894] [docs] Fix misleading HA docs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3401: [FLINK-5894] [docs] Fix misleading HA docs

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/3401


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3401: [FLINK-5894] [docs] Fix misleading HA docs

Posted by uce <gi...@git.apache.org>.
Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3401#discussion_r102705082
  
    --- Diff: docs/setup/jobmanager_high_availability.md ---
    @@ -84,12 +84,11 @@ In order to start an HA-cluster add the following configuration keys to `conf/fl
     
       **Important**: if you are running multiple Flink HA clusters, you have to manually configure separate namespaces for each cluster. By default, the Yarn cluster and the Yarn session automatically generate namespaces based on Yarn application id. A manual configuration overrides this behaviour in Yarn. Specifying a namespace with the -z CLI option, in turn, overrides manual configuration.
     
    -- **State backend and storage directory** (required): JobManager meta data is persisted in the *state backend* and only a pointer to this state is stored in ZooKeeper. Currently, only the file system state backend is supported in HA mode.
    +- **Storage directory** (required): JobManager meta data is persisted in the file system *storageDir* and only a pointer to this state is stored in ZooKeeper.
    --- End diff --
    
    Sure! I'm going to change and merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #3401: [FLINK-5894] [docs] Fix misleading HA docs

Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on the issue:

    https://github.com/apache/flink/pull/3401
  
    Would be better to spell metadata as one word. Otherwise looks great to me.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #3401: [FLINK-5894] [docs] Fix misleading HA docs

Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3401#discussion_r102703065
  
    --- Diff: docs/setup/jobmanager_high_availability.md ---
    @@ -84,12 +84,11 @@ In order to start an HA-cluster add the following configuration keys to `conf/fl
     
       **Important**: if you are running multiple Flink HA clusters, you have to manually configure separate namespaces for each cluster. By default, the Yarn cluster and the Yarn session automatically generate namespaces based on Yarn application id. A manual configuration overrides this behaviour in Yarn. Specifying a namespace with the -z CLI option, in turn, overrides manual configuration.
     
    -- **State backend and storage directory** (required): JobManager meta data is persisted in the *state backend* and only a pointer to this state is stored in ZooKeeper. Currently, only the file system state backend is supported in HA mode.
    +- **Storage directory** (required): JobManager meta data is persisted in the file system *storageDir* and only a pointer to this state is stored in ZooKeeper.
    --- End diff --
    
    It's generally agreed that metadata is one word.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---