You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/02/05 12:34:13 UTC
[GitHub] [hive] ArkoSharma opened a new pull request #1949: HIVE-24744: Deletion of previous dump dir fails with NPE for ptests
ArkoSharma opened a new pull request #1949:
URL: https://github.com/apache/hive/pull/1949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha merged pull request #1949: HIVE-24744: Deletion of previous dump dir fails with NPE for ptests
Posted by GitBox <gi...@apache.org>.
aasha merged pull request #1949:
URL: https://github.com/apache/hive/pull/1949
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aasha commented on a change in pull request #1949: HIVE-24744: Deletion of previous dump dir fails with NPE for ptests
Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #1949:
URL: https://github.com/apache/hive/pull/1949#discussion_r571816388
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -311,8 +311,11 @@ private void prepareReturnValues(List<String> values) throws SemanticException {
}
private void deleteAllPreviousDumpMeta(Path currentDumpPath) {
+ Path dumpRoot = getDumpRoot(currentDumpPath);
Review comment:
Do it inside the try catch block. replication shouldn't fail if getDumpRoot throws exception
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org