[GitHub] [shardingsphere] sandynz commented on a diff in pull request #25055: Improve inventory task dumper at pipeline

["sandynz (via GitHub)" <gi...@apache.org>]

sandynz commented on code in PR #25055:
URL: https://github.com/apache/shardingsphere/pull/25055#discussion_r1160650470


##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/InventoryDumper.java:
##########
@@ -188,9 +190,12 @@ private DataRecord loadDataRecord(final ResultSet resultSet, final ResultSetMeta
         DataRecord result = new DataRecord(newPosition(resultSet), columnCount);
         result.setType(IngestDataChangeType.INSERT);
         result.setTableName(dumperConfig.getLogicTableName());
+        List<String> insertColumnNames = Optional.ofNullable(dumperConfig.getInsertColumnNames()).orElse(Collections.emptyList());

Review Comment:
   Could we verify `resultSetMetaData.getColumnCount()` is equals with `dumperConfig.getInsertColumnNames().size`?



##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/task/InventoryIncrementalTasksRunner.java:
##########
@@ -49,6 +49,7 @@ public class InventoryIncrementalTasksRunner implements PipelineTasksRunner {
     
     private final Collection<IncrementalTask> incrementalTasks;
     
+    @Getter
     private final PipelineJobAPI jobAPI;

Review Comment:
   Is `@Getter` required?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org