You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/01 06:56:25 UTC
[jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
This cleans up the azure management api so that we can start working on it again. This doesn't mean cleanups are done. this is just the first stab.
It does the following.
* removes async stuff
* move off deprecated core code (ex RestApiModule)
* fixes random annotation problems
* fix a ton of checkstyle issues
* rewrite the expect tests as mock tests
* remove the directory trees of unused model classes.
* minimally reworks existing domain objects so that they pass checkstyle etc.
* clear up naming around image
In all, this removes over 3k lines of debt. After this, we can start clearing up the api interfaces, updating to any changes in the azure api since written, think about compute service integration.
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs adrian.cleanup-azure-management
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs/pull/76
-- Commit Summary --
* JCLOUDS-664 Removed dead code and refactored good code.
-- File Changes --
M azure-management/pom.xml (57)
M azure-management/src/main/java/org/jclouds/azure/management/AzureManagementApi.java (51)
M azure-management/src/main/java/org/jclouds/azure/management/AzureManagementApiMetadata.java (40)
D azure-management/src/main/java/org/jclouds/azure/management/AzureManagementAsyncApi.java (94)
M azure-management/src/main/java/org/jclouds/azure/management/AzureManagementProviderMetadata.java (8)
M azure-management/src/main/java/org/jclouds/azure/management/binders/BindCreateHostedServiceToXmlPayload.java (15)
M azure-management/src/main/java/org/jclouds/azure/management/binders/BindDeploymentParamsToXmlPayload.java (173)
M azure-management/src/main/java/org/jclouds/azure/management/binders/BindOSImageParamsToXmlPayload.java (10)
M azure-management/src/main/java/org/jclouds/azure/management/compute/AzureManagementComputeServiceAdapter.java (171)
M azure-management/src/main/java/org/jclouds/azure/management/compute/config/AzureManagementComputeServiceContextModule.java (16)
M azure-management/src/main/java/org/jclouds/azure/management/compute/functions/DeploymentToNodeMetadata.java (3)
M azure-management/src/main/java/org/jclouds/azure/management/compute/functions/OSImageToImage.java (8)
M azure-management/src/main/java/org/jclouds/azure/management/compute/functions/RoleSizeToHardware.java (3)
R azure-management/src/main/java/org/jclouds/azure/management/config/AzureManagementHttpApiModule.java (24)
M azure-management/src/main/java/org/jclouds/azure/management/config/AzureManagementProperties.java (6)
D azure-management/src/main/java/org/jclouds/azure/management/config/AzureManagementRestClientModule.java (75)
M azure-management/src/main/java/org/jclouds/azure/management/domain/Deployment.java (569)
M azure-management/src/main/java/org/jclouds/azure/management/domain/DeploymentParams.java (370)
M azure-management/src/main/java/org/jclouds/azure/management/domain/DeploymentSlot.java (35)
M azure-management/src/main/java/org/jclouds/azure/management/domain/DeploymentStatus.java (4)
M azure-management/src/main/java/org/jclouds/azure/management/domain/DetailedHostedServiceProperties.java (81)
M azure-management/src/main/java/org/jclouds/azure/management/domain/Disk.java (207)
M azure-management/src/main/java/org/jclouds/azure/management/domain/Error.java (40)
M azure-management/src/main/java/org/jclouds/azure/management/domain/HostedService.java (21)
M azure-management/src/main/java/org/jclouds/azure/management/domain/HostedServiceProperties.java (16)
M azure-management/src/main/java/org/jclouds/azure/management/domain/HostedServiceWithDetailedProperties.java (26)
R azure-management/src/main/java/org/jclouds/azure/management/domain/Image.java (163)
R azure-management/src/main/java/org/jclouds/azure/management/domain/ImageParams.java (66)
M azure-management/src/main/java/org/jclouds/azure/management/domain/InputEndpoint.java (4)
M azure-management/src/main/java/org/jclouds/azure/management/domain/InstanceStatus.java (6)
M azure-management/src/main/java/org/jclouds/azure/management/domain/Location.java (29)
M azure-management/src/main/java/org/jclouds/azure/management/domain/OSType.java (4)
M azure-management/src/main/java/org/jclouds/azure/management/domain/Operation.java (18)
R azure-management/src/main/java/org/jclouds/azure/management/domain/Protocol.java (14)
M azure-management/src/main/java/org/jclouds/azure/management/domain/RoleSize.java (35)
D azure-management/src/main/java/org/jclouds/azure/management/domain/hostedservice/CreateDeployment.java (214)
D azure-management/src/main/java/org/jclouds/azure/management/domain/hostedservice/ExtendedProperty.java (102)
D azure-management/src/main/java/org/jclouds/azure/management/domain/hostedservice/package-info.java (24)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/AbstractRole.java (143)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/DNS.java (78)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/DNSServer.java (93)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/DataVirtualHardDisk.java (57)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/Deployment.java (185)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/HostCaching.java (29)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/OSVirtualHardDisk.java (66)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/PersistentVMRole.java (24)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/Role.java (24)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/RoleSize.java (36)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/VirtualHardDisk.java (88)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/CertificateSetting.java (78)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/ConfigurationSet.java (47)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/ConfigurationSetAdapter.java (150)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/Credentials.java (75)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/DomainJoin.java (78)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/InputEndpoint.java (141)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/KeyPair.java (32)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/LinuxProvisioningConfiguration.java (105)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/LoadBalancerProbe.java (81)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/NetworkConfiguration.java (68)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/PublicKey.java (32)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/SSH.java (67)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/SSHKey.java (55)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/WindowsProvisioningConfiguration.java (140)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/conf/package-info.java (25)
D azure-management/src/main/java/org/jclouds/azure/management/domain/role/package-info.java (25)
M azure-management/src/main/java/org/jclouds/azure/management/features/DiskApi.java (40)
D azure-management/src/main/java/org/jclouds/azure/management/features/DiskAsyncApi.java (71)
M azure-management/src/main/java/org/jclouds/azure/management/features/HostedServiceApi.java (137)
D azure-management/src/main/java/org/jclouds/azure/management/features/HostedServiceAsyncApi.java (155)
R azure-management/src/main/java/org/jclouds/azure/management/features/ImageApi.java (67)
M azure-management/src/main/java/org/jclouds/azure/management/features/LocationApi.java (27)
D azure-management/src/main/java/org/jclouds/azure/management/features/LocationAsyncApi.java (58)
D azure-management/src/main/java/org/jclouds/azure/management/features/OSImageApi.java (63)
M azure-management/src/main/java/org/jclouds/azure/management/features/OperationApi.java (25)
D azure-management/src/main/java/org/jclouds/azure/management/features/OperationAsyncApi.java (55)
M azure-management/src/main/java/org/jclouds/azure/management/features/RoleApi.java (87)
D azure-management/src/main/java/org/jclouds/azure/management/features/RoleAsyncApi.java (137)
M azure-management/src/main/java/org/jclouds/azure/management/functions/OSImageParamsName.java (15)
M azure-management/src/main/java/org/jclouds/azure/management/functions/ParseRequestIdHeader.java (8)
M azure-management/src/main/java/org/jclouds/azure/management/options/CreateHostedServiceOptions.java (26)
M azure-management/src/main/java/org/jclouds/azure/management/suppliers/KeyStoreSupplier.java (14)
M azure-management/src/main/java/org/jclouds/azure/management/suppliers/SSLContextWithKeysSupplier.java (9)
M azure-management/src/main/java/org/jclouds/azure/management/xml/AttachmentHandler.java (9)
M azure-management/src/main/java/org/jclouds/azure/management/xml/DeploymentHandler.java (163)
M azure-management/src/main/java/org/jclouds/azure/management/xml/DetailedHostedServicePropertiesHandler.java (20)
M azure-management/src/main/java/org/jclouds/azure/management/xml/DiskHandler.java (28)
M azure-management/src/main/java/org/jclouds/azure/management/xml/ErrorHandler.java (10)
M azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServiceHandler.java (30)
M azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServicePropertiesHandler.java (18)
M azure-management/src/main/java/org/jclouds/azure/management/xml/HostedServiceWithDetailedPropertiesHandler.java (6)
R azure-management/src/main/java/org/jclouds/azure/management/xml/ImageHandler.java (29)
M azure-management/src/main/java/org/jclouds/azure/management/xml/ListDisksHandler.java (29)
M azure-management/src/main/java/org/jclouds/azure/management/xml/ListHostedServicesHandler.java (29)
R azure-management/src/main/java/org/jclouds/azure/management/xml/ListImagesHandler.java (35)
M azure-management/src/main/java/org/jclouds/azure/management/xml/ListLocationsHandler.java (29)
M azure-management/src/main/java/org/jclouds/azure/management/xml/LocationHandler.java (10)
M azure-management/src/main/java/org/jclouds/azure/management/xml/OperationHandler.java (32)
D azure-management/src/test/java/org/jclouds/azure/management/features/DiskApiExpectTest.java (81)
M azure-management/src/test/java/org/jclouds/azure/management/features/DiskApiLiveTest.java (38)
A azure-management/src/test/java/org/jclouds/azure/management/features/DiskApiMockTest.java (88)
D azure-management/src/test/java/org/jclouds/azure/management/features/HostedServiceApiExpectTest.java (168)
M azure-management/src/test/java/org/jclouds/azure/management/features/HostedServiceApiLiveTest.java (43)
A azure-management/src/test/java/org/jclouds/azure/management/features/HostedServiceApiMockTest.java (185)
R azure-management/src/test/java/org/jclouds/azure/management/features/ImageApiLiveTest.java (41)
A azure-management/src/test/java/org/jclouds/azure/management/features/ImageApiMockTest.java (127)
D azure-management/src/test/java/org/jclouds/azure/management/features/LocationApiExpectTest.java (59)
M azure-management/src/test/java/org/jclouds/azure/management/features/LocationApiLiveTest.java (28)
A azure-management/src/test/java/org/jclouds/azure/management/features/LocationApiMockTest.java (58)
D azure-management/src/test/java/org/jclouds/azure/management/features/OSImageApiExpectTest.java (115)
D azure-management/src/test/java/org/jclouds/azure/management/features/OperationApiExpectTest.java (55)
A azure-management/src/test/java/org/jclouds/azure/management/features/OperationApiMockTest.java (59)
D azure-management/src/test/java/org/jclouds/azure/management/features/RoleApiExpectTest.java (173)
A azure-management/src/test/java/org/jclouds/azure/management/features/RoleApiMockTest.java (119)
M azure-management/src/test/java/org/jclouds/azure/management/internal/BaseAzureManagementApiLiveTest.java (28)
A azure-management/src/test/java/org/jclouds/azure/management/internal/BaseAzureManagementApiMockTest.java (95)
D azure-management/src/test/java/org/jclouds/azure/management/internal/BaseAzureManagementAsyncApiExpectTest.java (32)
D azure-management/src/test/java/org/jclouds/azure/management/internal/BaseAzureManagementExpectTest.java (55)
M azure-management/src/test/java/org/jclouds/azure/management/parse/ErrorTest.java (6)
M azure-management/src/test/java/org/jclouds/azure/management/parse/GetDeploymentTest.java (7)
M azure-management/src/test/java/org/jclouds/azure/management/parse/GetHostedServiceDetailsTest.java (10)
M azure-management/src/test/java/org/jclouds/azure/management/parse/GetHostedServiceTest.java (8)
M azure-management/src/test/java/org/jclouds/azure/management/parse/GetOperationTest.java (9)
M azure-management/src/test/java/org/jclouds/azure/management/parse/ListDisksTest.java (12)
M azure-management/src/test/java/org/jclouds/azure/management/parse/ListHostedServicesTest.java (17)
R azure-management/src/test/java/org/jclouds/azure/management/parse/ListImagesTest.java (41)
M azure-management/src/test/java/org/jclouds/azure/management/parse/ListLocationsTest.java (19)
M azure-management/src/test/resources/disks.xml (2)
M azure-management/src/test/resources/images.xml (2)
M azure-management/src/test/resources/locations.xml (2)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/76.patch
https://github.com/jclouds/jclouds-labs/pull/76.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #278](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/278/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57551135
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Ignasi Barrera <no...@github.com>.
Just a quick note for the cleanup regarding authentication (I really don't know which is the better place to comment this :)). Azure authentication sucks, and they still don't provide complete OAuth support in their API, so we have to use SSL client certificates. The current implementation uses the `KeyStore`, but perhaps we could cleanup and simplify it a bit by using a custom `KeyManager` instead. I've done a couple experiments with their official client and this approach and it seems to work: https://gist.github.com/nacx/a78b0dbe246d38814adb
WDYT?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57432353
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> -
> - }
> -
> - @Override
> - public Iterable<Deployment> listNodes() {
> - // TODO Auto-generated method stub
> - return null;
> - }
> -
> +public class AzureManagementComputeServiceAdapter
> + implements ComputeServiceAdapter<Deployment, RoleSize, Image, String> {
> +
> + @Override
> + public org.jclouds.compute.ComputeServiceAdapter.NodeAndInitialCredentials<Deployment> createNodeWithGroupEncodedIntoName(
> + String group, String name, Template template) {
> + // TODO Auto-generated method stub
Intentional to have all these stubs here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261580
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> + * virtual machine to fail to start. Contact support for additional
> + * assistance.
> + *
> + * For web and worker roles this field returns an error code that can be provided to Windows Azure support to assist
> + * in resolution of errors. Typically this field will be empty.
> + */
> + private final String instanceErrorCode;
> +
> + /**
> + * The size of the role instance
> + */
> + private final RoleSize instanceSize;
> + private final String privateIpAddress;
> + private final String publicIpAddress;
> +
> + public Deployment(String deploymentName, DeploymentSlot deploymentSlot, DeploymentStatus deploymentStatus,
Is this created other than by a builder? I.e. narrow the access to `protected` or package-level?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261628
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> /**
> * @see <a href="http://msdn.microsoft.com/en-us/library/jj157176" >api</a>
> */
> public class DiskHandler extends
> ParseSax.HandlerForGeneratedRequestWithResult<Disk> {
>
> - protected final AttachmentHandler attachmentHandler;
> + private final AttachmentHandler attachmentHandler;
Some obvious things that should have never been shared I changed to private
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261987
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> <description>jclouds components to access an implementation of Azure Management</description>
> <packaging>bundle</packaging>
>
> <properties>
> - <test.jclouds.azure.management.subscription-id>FIXME_subscription-id</test.jclouds.azure.management.subscription-id>
> + <test.jclouds.azure-management.subscription-id>FIXME_subscription-id</test.jclouds.azure-management.subscription-id>
this corresponds to a provider property that starts with jclouds.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261625
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> */
> - @Named("DeleteOsImage")
> + @Named("DeleteImage")
> @DELETE
> @Path("/services/images/{imageName}")
Same "common prefix?" question as above.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261801
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> /**
> * @see <a href="http://msdn.microsoft.com/en-us/library/jj157176" >api</a>
> */
> public class DiskHandler extends
> ParseSax.HandlerForGeneratedRequestWithResult<Disk> {
>
> - protected final AttachmentHandler attachmentHandler;
> + private final AttachmentHandler attachmentHandler;
Any particular reason for the visibility change here and similarly elsewhere?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261920
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> + // TODO Since the roleName should be unique, is it a good idea to copy it ?
> + return this.name(in.getName()).sourceImageName(in.getSourceImageName()).username(in.getUsername())
> + .password(in.getPassword()).size(in.getSize());
> + }
> + }
> +
> + private final String name;
> + private final String sourceImageName;
> + private final String username;
> + private final String password;
> + private final String storageAccount;
> + private final RoleSize size;
> + private final OSType osType;
> + private final List<InputEndpoint> endpoints;
> +
> + public DeploymentParams(String name, String sourceImageName, String username, String password, String storageAccount,
See comment above about domain object constructor visibility
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261657
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> + * virtual machine to fail to start. Contact support for additional
> + * assistance.
> + *
> + * For web and worker roles this field returns an error code that can be provided to Windows Azure support to assist
> + * in resolution of errors. Typically this field will be empty.
> + */
> + private final String instanceErrorCode;
> +
> + /**
> + * The size of the role instance
> + */
> + private final RoleSize instanceSize;
> + private final String privateIpAddress;
> + private final String publicIpAddress;
> +
> + public Deployment(String deploymentName, DeploymentSlot deploymentSlot, DeploymentStatus deploymentStatus,
actually there are a ton of things like this. let me leave fixing up the domain files for a separate PR
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261799
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
>
> - private List<String> elements = Lists.newArrayList();
> - protected StringBuilder currentText = new StringBuilder();
> - private Deployment.Builder builder = Deployment.builder();
> + @Override
> + public Deployment getResult() {
> + try {
> + return builder.build();
> + } finally {
> + builder = Deployment.builder();
> + }
I guess this is equivalent, but would something "boring" like:
```
Deployment deployment = builder.build();
builder = Deployment.builder();
return deployment;
```
not work here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261883
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> + this.osType = osType;
> + return this;
> + }
> +
> + public Builder endpoint(InputEndpoint endpoint) {
> + endpoints.add(endpoint);
> + return this;
> + }
> +
> + public DeploymentParams build() {
> + return new DeploymentParams(name, sourceImageName, username, password, storageAccount, size, osType,
> + endpoints);
> + }
> +
> + public Builder fromDeploymentParams(DeploymentParams in) {
> + // TODO Since the roleName should be unique, is it a good idea to copy it ?
Is `name` the "roleName" here?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261652
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #276](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/276/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57548113
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> import com.google.common.base.CaseFormat;
>
> +import static com.google.common.base.Preconditions.checkNotNull;
> +
> public enum DeploymentStatus {
> RUNNING, SUSPENDED, RUNNING_TRANSITIONING, SUSPENDED_TRANSITIONING, STARTING, SUSPENDING, DEPLOYING, DELETING;
[minor] Does this need some wrapping?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261671
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1569](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1569/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57419796
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1576](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1576/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57547459
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
ok so I've done all I'm prepared to in the next day or two. Most notably, the live tests work again. Hope we can get this merged so others can help chip in as well.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57507550
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> */
> +@Headers(keys = "x-ms-version", values = "2012-03-01")
Worth pulling "2012-03-01" out into a constant?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261767
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> public interface DiskApi {
>
> /**
> * The List Disks operation retrieves a list of the disks in your image repository.
> */
> - Set<Disk> list();
> + @Named("ListDisks")
> + @GET
> + @Path("/services/disks")
Can this be moved to the interface level as a common prefix?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261777
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #277](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/277/) FAILURE
Looks like there's a problem with this pull request
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57546724
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> + this.roleName = roleName;
> + return this;
> + }
> +
> + public Deployment build() {
> + return new Deployment(deploymentName, deploymentSlot, deploymentStatus, deploymentLabel, deploymentURL,
> + roleName, instanceName, instanceStatus, instanceStateDetails, instanceErrorCode, instanceSize,
> + privateIpAddress, publicIpAddress);
> + }
> +
> + }
> +
> + /**
> + * The user-supplied name for this deployment.
> + */
> + private final String deploymentName;
I take it back.. this pattern is in a ton of places, so yeah want to conserve time.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18262039
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> */
> - String createDeployment(String serviceName, DeploymentParams deploymentParams);
> + @Named("CreateVirtualMachineDeployment")
> + @POST
> + @Path("/services/hostedservices/{serviceName}/deployments")
> + @Produces(MediaType.APPLICATION_XML)
> + @ResponseParser(ParseRequestIdHeader.class)
> + String createDeployment(@PathParam("serviceName") String serviceName,
Does thie belong in the HostedServiceApi?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261831
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> +
> + inputEndpoints.up();
> + configBuilder.e("SubnetNames").up()
> + .up();
> +
> + builder.up() //ConfigurationSets
> + .e("DataVirtualHardDisks").up()
> + .e("OSVirtualHardDisk")
> + .e("HostCaching").t("ReadWrite").up()
> + .e("MediaLink").t(url(params)).up()
> + .e("SourceImageName").t(params.getSourceImageName()).up()
> + .e("OS").t("Linux").up()
> + .up() //OSVirtualHardDisk
> + .e("RoleSize").t(params.getSize().value()).up()
> + .up() //Role
> + .up(); //RoleList
Yay! Don't you love XML serialization! ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261567
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
@demobox so just to set expectations, I'm not going to fix all problems in azure in this pr. There are still quite many left.. equals/hashcode screwups, wrong names in javadac, or bad javadoc, visibility etc. This PR is just to get the project into a state where I can look at the code. For example, I don't want to spend time polishing objects that are no longer in the current api.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57420527
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1578](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1578/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57550937
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> * @see <a href="http://msdn.microsoft.com/en-us/library/ee460786">docs</a>
> */
> - public static final String SUBSCRIPTION_ID = "jclouds.azure.management.subscription-id";
> + public static final String SUBSCRIPTION_ID = "jclouds.azure-management.subscription-id";
Ah, I see where the `jclouds` part of this property probably cam from...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261592
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #270](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/270/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57419708
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <ad...@gmail.com>.
I will do another pass on this PR, updating the api to latest version and
more cleanups. Afterwards, lets try to merge so others can help test and
finish up.
Sound good?
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
Good point. the authentication code here is a mess on the todo list. Let's
address that in a follow-up. Might be that KeyManager is the way out.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57472260
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> + this.osType = osType;
> + return this;
> + }
> +
> + public Builder endpoint(InputEndpoint endpoint) {
> + endpoints.add(endpoint);
> + return this;
> + }
> +
> + public DeploymentParams build() {
> + return new DeploymentParams(name, sourceImageName, username, password, storageAccount, size, osType,
> + endpoints);
> + }
> +
> + public Builder fromDeploymentParams(DeploymentParams in) {
> + // TODO Since the roleName should be unique, is it a good idea to copy it ?
maybe. this is an old comment and I've not analyzed this or the other todos, yet
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18262060
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1575](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1575/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57512226
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> + this.roleName = roleName;
> + return this;
> + }
> +
> + public Deployment build() {
> + return new Deployment(deploymentName, deploymentSlot, deploymentStatus, deploymentLabel, deploymentURL,
> + roleName, instanceName, instanceStatus, instanceStateDetails, instanceErrorCode, instanceSize,
> + privateIpAddress, publicIpAddress);
> + }
> +
> + }
> +
> + /**
> + * The user-supplied name for this deployment.
> + */
> + private final String deploymentName;
Are users more likely to see the Javadoc here or on the builder?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261612
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1570](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1570/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57420521
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> */
> - String startRole(String serviceName, String deploymentName, String roleName);
> -
> + @Named("StartRole")
> + @POST
> + @Path("/services/hostedservices/{serviceName}/deployments/{deploymentName}/roleInstances/{roleName}/Operations")
The usual common prefix comment
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261837
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> @@ -47,9 +45,9 @@ public void test() {
>
> }
>
> - protected final DateService dateService = new SimpleDateFormatDateService();
> + private static final DateService dateService = new SimpleDateFormatDateService();
Just to verify...`SimpleDateFormatDateService` is indeed thread-safe..?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18262014
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
@demobox so to help save you time, before this PR, we couldn't build azure-management at all. I'm not happy with the api organization, but certainly won't address that here either. this is just to weed out the better stuff from the horrible stuff. For example, I'm not even sure we want a HostedServiceApi that looks like this (or RoleApi for that matter). I don't want to polish too much on the internals there until revisiting docs and seeing how things match up.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57420727
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> -
> - }
> -
> - @Override
> - public Iterable<Deployment> listNodes() {
> - // TODO Auto-generated method stub
> - return null;
> - }
> -
> +public class AzureManagementComputeServiceAdapter
> + implements ComputeServiceAdapter<Deployment, RoleSize, Image, String> {
> +
> + @Override
> + public org.jclouds.compute.ComputeServiceAdapter.NodeAndInitialCredentials<Deployment> createNodeWithGroupEncodedIntoName(
> + String group, String name, Template template) {
> + // TODO Auto-generated method stub
this was reformatting for checkstyle, etc.. we'll get to implementing in a bit.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261642
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> */
> +@Headers(keys = "x-ms-version", values = "2012-03-01")
> probably, but more helpful pulling 2014-something into a constant :P
*grin*. Well, one step (year?) at a time... ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18262192
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #274](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/274/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57510594
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Ignasi Barrera <no...@github.com>.
>Sound good?
+1
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57484439
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> import com.google.common.base.CaseFormat;
>
> +import static com.google.common.base.Preconditions.checkNotNull;
> +
> public enum DeploymentStatus {
> RUNNING, SUSPENDED, RUNNING_TRANSITIONING, SUSPENDED_TRANSITIONING, STARTING, SUSPENDING, DEPLOYING, DELETING;
this will need scrubbing when we update to 2014-06-01, so can handle then.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18310693
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> @Override
> - public Set<Disk> getResult() {
> + public List<Disk> getResult() {
Change here and similarly below caused by changes to the API? Or was the domain model simply wrong?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261942
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #275](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/275/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57509431
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> @@ -47,9 +45,9 @@ public void test() {
>
> }
>
> - protected final DateService dateService = new SimpleDateFormatDateService();
> + private static final DateService dateService = new SimpleDateFormatDateService();
this is a test class w/ a single method. so no worries.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18310651
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
>
> - private List<String> elements = Lists.newArrayList();
> - protected StringBuilder currentText = new StringBuilder();
> - private Deployment.Builder builder = Deployment.builder();
> + @Override
> + public Deployment getResult() {
> + try {
> + return builder.build();
> + } finally {
> + builder = Deployment.builder();
> + }
the approach you are commenting on is in a ton of other files, but yeah, we can do the shell game instead of try and reset.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18262023
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> <description>jclouds components to access an implementation of Azure Management</description>
> <packaging>bundle</packaging>
>
> <properties>
> - <test.jclouds.azure.management.subscription-id>FIXME_subscription-id</test.jclouds.azure.management.subscription-id>
> + <test.jclouds.azure-management.subscription-id>FIXME_subscription-id</test.jclouds.azure-management.subscription-id>
[minor] Just `<test.azure-management.subscription-id>`? Or is there some good reason to have the "jclouds" in there?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261522
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1574](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1574/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57509822
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
Closed #76.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#event-173535979
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> @Override
> - public Set<Disk> getResult() {
> + public List<Disk> getResult() {
We've always been wrong using Set for things like this. there was an old convo with tim p about this.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261972
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> * @param serviceName
> * the unique DNS Prefix value in the Windows Azure Management Portal
> * @param deploymentName
> * the unique DNS Prefix value in the Windows Azure Management Portal
> */
> - Deployment getDeployment(String serviceName, String deploymentName);
> -
> + @Named("GetDeployment")
> + @GET
> + @Path("/services/hostedservices/{serviceName}/deployments/{deploymentName}")
Can `/services/hostedservices/` be hoisted to the interface level as a common prefix?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261790
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
>
> - private List<String> elements = Lists.newArrayList();
> - protected StringBuilder currentText = new StringBuilder();
> - private Deployment.Builder builder = Deployment.builder();
> + @Override
> + public Deployment getResult() {
> + try {
> + return builder.build();
> + } finally {
> + builder = Deployment.builder();
> + }
> the approach you are commenting on is in a ton of other files
Then let's leave as-is - thanks for explaining.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18262074
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> */
> +@Headers(keys = "x-ms-version", values = "2012-03-01")
probably, but more helpful pulling 2014-something into a constant :P
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18262072
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> <description>jclouds components to access an implementation of Azure Management</description>
> <packaging>bundle</packaging>
>
> <properties>
> - <test.jclouds.azure.management.subscription-id>FIXME_subscription-id</test.jclouds.azure.management.subscription-id>
> + <test.jclouds.azure-management.subscription-id>FIXME_subscription-id</test.jclouds.azure-management.subscription-id>
> this corresponds to a provider property that starts with jclouds.
I saw the `SUBSCRIPTION_ID` constant later. Thanks for explaining!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261692
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
@demobox I think we should be good to merge at this point. Here are the latest changes.
* renamed to azurecompute
* clear up naming around image and virtual machine
* extract common parameters needed for apis so that the arg lists are shorter
* made api version not hard-coded in each api class
Live tests still pass. Next step after this is to update to 2014-06-01, so that we add the VirtualMachine class (aka Role), which will be what NodeMetadata is derived from. Now's a good milestone, though.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57544641
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
Merged to [master](https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;a=commit;h=6ab58bd2ef0a644b1d5b7d65a6053cf6220c7165). Thanks, @adriancole!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57716572
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> + this.roleName = roleName;
> + return this;
> + }
> +
> + public Deployment build() {
> + return new Deployment(deploymentName, deploymentSlot, deploymentStatus, deploymentLabel, deploymentURL,
> + roleName, instanceName, instanceStatus, instanceStateDetails, instanceErrorCode, instanceSize,
> + privateIpAddress, publicIpAddress);
> + }
> +
> + }
> +
> + /**
> + * The user-supplied name for this deployment.
> + */
> + private final String deploymentName;
hah yeah good point. I'm not done with these files. They'll probably need a couple more sweeps (hopefully ok in follow-up pull requests)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261660
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Andrew Phillips <no...@github.com>.
> I don't want to polish too much on the internals there until revisiting docs and seeing how things match
> up.
Sure, makes sense. I just wanted to flag it up as I went by.
Thanks for getting this started! Glad to see so much dead code disappearing...
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57421057
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
@demobox yeah I will knock on the things you mentioned later, especially putting docs where they should (or delete them), visibility sweep, re-org methods that are probably in the wrong apis or are a train-wreck of string params, etc. too
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57421262
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #269](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/269/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57419384
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by Adrian Cole <no...@github.com>.
> + this.roleName = roleName;
> + return this;
> + }
> +
> + public Deployment build() {
> + return new Deployment(deploymentName, deploymentSlot, deploymentStatus, deploymentLabel, deploymentURL,
> + roleName, instanceName, instanceStatus, instanceStateDetails, instanceErrorCode, instanceSize,
> + privateIpAddress, publicIpAddress);
> + }
> +
> + }
> +
> + /**
> + * The user-supplied name for this deployment.
> + */
> + private final String deploymentName;
actually I can handle this one.. np
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76/files#r18261668
Re: [jclouds-labs] JCLOUDS-664 Removed dead code and refactored good
code. (#76)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1577](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1577/) FAILURE
Looks like there's a problem with this pull request
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/76#issuecomment-57547938