You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/01/23 09:08:14 UTC

[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #5464: Add license to RPMs

zrhoffman commented on a change in pull request #5464:
URL: https://github.com/apache/trafficcontrol/pull/5464#discussion_r563041405



##########
File path: test/fakeOrigin/build/build_rpm.sh
##########
@@ -70,7 +71,7 @@ cp $BUILDDIR/RPMS/x86_64/*.rpm ./dist/
 # Cross compile because we can
 GOBINEXT=""
 for GOOS in darwin linux windows; do
-  for GOARCH in 386 amd64; do
+  for GOARCH in amd64; do

Review comment:
       There was a build error when trying to build the darwin/386 GOOS/GOARCH pair because Go does not support that pair (766e5aa1b0). I removed it so that fakeOrigin's build_rpm.sh would exit successfully.
   
   Do we care about 32-bit support? If so, we could just skip over the darwin/386 pair.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org