You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by em...@apache.org on 2022/01/18 08:12:32 UTC

[thrift] branch master updated: Fix warning C4515: 'protocol': namespace uses itself

This is an automated email from the ASF dual-hosted git repository.

emmenlau pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git


The following commit(s) were added to refs/heads/master by this push:
     new b3cf198  Fix warning C4515: 'protocol': namespace uses itself
     new b1dc2ae  Merge pull request #2505 from dsandbrink/patch-1
b3cf198 is described below

commit b3cf1980582d026def0fc262de8a788d5b34ca85
Author: Dirk Sandbrink <ds...@users.noreply.github.com>
AuthorDate: Mon Jan 17 14:12:25 2022 +0100

    Fix warning C4515: 'protocol': namespace uses itself
    
    This warning can been seen when compiling generated code using Visual Studio 16.11.
---
 lib/cpp/src/thrift/protocol/TList.h | 2 --
 lib/cpp/src/thrift/protocol/TMap.h  | 2 --
 lib/cpp/src/thrift/protocol/TSet.h  | 2 --
 3 files changed, 6 deletions(-)

diff --git a/lib/cpp/src/thrift/protocol/TList.h b/lib/cpp/src/thrift/protocol/TList.h
index bf2c1f9..0e58be2 100644
--- a/lib/cpp/src/thrift/protocol/TList.h
+++ b/lib/cpp/src/thrift/protocol/TList.h
@@ -26,8 +26,6 @@ namespace apache {
 namespace thrift {
 namespace protocol {
 
-// using namespace apache::thrift::protocol;
-
 /**
  * Helper class that encapsulates list metadata.
  *
diff --git a/lib/cpp/src/thrift/protocol/TMap.h b/lib/cpp/src/thrift/protocol/TMap.h
index b52ea8f..89825c8 100644
--- a/lib/cpp/src/thrift/protocol/TMap.h
+++ b/lib/cpp/src/thrift/protocol/TMap.h
@@ -26,8 +26,6 @@ namespace apache {
 namespace thrift {
 namespace protocol {
 
-using namespace apache::thrift::protocol;
-
 /**
  * Helper class that encapsulates map metadata.
  *
diff --git a/lib/cpp/src/thrift/protocol/TSet.h b/lib/cpp/src/thrift/protocol/TSet.h
index 3a4718c..01f4b02 100644
--- a/lib/cpp/src/thrift/protocol/TSet.h
+++ b/lib/cpp/src/thrift/protocol/TSet.h
@@ -27,8 +27,6 @@ namespace apache {
 namespace thrift {
 namespace protocol {
 
-using namespace apache::thrift::protocol;
-
 /**
  * Helper class that encapsulates set metadata.
  *