You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Marko Malenic <mm...@gmail.com> on 2021/02/17 03:25:38 UTC
[STATISTICS] Truncated Normal Distribution
Hi all,
I've completed an implementation of a truncated normal distribution for
commons-statistics,
as described by:
https://issues.apache.org/jira/browse/STATISTICS-27
at:
https://github.com/mmalenic/commons-statistics/tree/STATISTICS-27-TruncatedNormalDistribution
When submitting a PR what is the preferred format for commits?
Should I squash all my commits into one, or leave my individual commits
(some of which do not pass build checks)?
Best,
Marko
Re: [STATISTICS] Truncated Normal Distribution
Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.
Le ven. 19 févr. 2021 à 08:43, Marko Malenic <mm...@gmail.com> a écrit :
>
> Hi Gilles,
>
> Thanks, I've sent that through, and opened a pull request on the
> commons-statistics github page.
Thanks!
Nit-pick: When you've implemented the changes suggested by Alex,
please mention the JIRA identifier in the commit message, i.e.:
---
STATISTICS-27: Implement truncated normal distribution.
---
Gilles
>> [...]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [STATISTICS] Truncated Normal Distribution
Posted by Marko Malenic <mm...@gmail.com>.
Hi Gilles,
Thanks, I've sent that through, and opened a pull request on the
commons-statistics github page.
Best,
Marko
On Fri, Feb 19, 2021 at 11:48 AM Gilles Sadowski <gi...@gmail.com>
wrote:
> Hi.
>
> Le ven. 19 févr. 2021 à 00:59, Marko Malenic <mm...@gmail.com> a
> écrit :
> >
> > Hi Gilles,
> >
> > Do I need to sign a contributor license agreement for this?
>
> Yes, it is preferable.[1]
> Thank you for asking.
>
> Regards,
> Gilles
>
> [1] http://www.apache.org/licenses/contributor-agreements.html
>
> > > [...]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [STATISTICS] Truncated Normal Distribution
Posted by Gilles Sadowski <gi...@gmail.com>.
Hi.
Le ven. 19 févr. 2021 à 00:59, Marko Malenic <mm...@gmail.com> a écrit :
>
> Hi Gilles,
>
> Do I need to sign a contributor license agreement for this?
Yes, it is preferable.[1]
Thank you for asking.
Regards,
Gilles
[1] http://www.apache.org/licenses/contributor-agreements.html
> > [...]
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [STATISTICS] Truncated Normal Distribution
Posted by Marko Malenic <mm...@gmail.com>.
Hi Gilles,
Do I need to sign a contributor license agreement for this?
Best,
Marko
On Wed, Feb 17, 2021 at 10:11 PM Gilles Sadowski <gi...@gmail.com>
wrote:
> Hello.
>
> Le mer. 17 févr. 2021 à 04:25, Marko Malenic <mm...@gmail.com> a
> écrit :
> >
> > Hi all,
> >
> > I've completed an implementation of a truncated normal distribution for
> > commons-statistics,
> > as described by:
> > https://issues.apache.org/jira/browse/STATISTICS-27
> > at:
> >
> https://github.com/mmalenic/commons-statistics/tree/STATISTICS-27-TruncatedNormalDistribution
> >
> > When submitting a PR what is the preferred format for commits?
> > Should I squash all my commits into one,
>
> Yes.
>
> Thanks,
> Gilles
>
> > or leave my individual commits
> > (some of which do not pass build checks)?
> >
> > Best,
> > Marko
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>
Re: [STATISTICS] Truncated Normal Distribution
Posted by Gilles Sadowski <gi...@gmail.com>.
Hello.
Le mer. 17 févr. 2021 à 04:25, Marko Malenic <mm...@gmail.com> a écrit :
>
> Hi all,
>
> I've completed an implementation of a truncated normal distribution for
> commons-statistics,
> as described by:
> https://issues.apache.org/jira/browse/STATISTICS-27
> at:
> https://github.com/mmalenic/commons-statistics/tree/STATISTICS-27-TruncatedNormalDistribution
>
> When submitting a PR what is the preferred format for commits?
> Should I squash all my commits into one,
Yes.
Thanks,
Gilles
> or leave my individual commits
> (some of which do not pass build checks)?
>
> Best,
> Marko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org