You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Dawid Weiss (JIRA)" <ji...@apache.org> on 2011/06/14 12:10:47 UTC
[jira] [Created] (LUCENE-3202) Add DataInput/DataOutput subclasses
that delegate to an InputStream/OutputStream.
Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.
---------------------------------------------------------------------------------
Key: LUCENE-3202
URL: https://issues.apache.org/jira/browse/LUCENE-3202
Project: Lucene - Java
Issue Type: Task
Components: core/other
Reporter: Dawid Weiss
Assignee: Dawid Weiss
Priority: Trivial
Fix For: 3.3, 4.0
Such classes would be handy for FST serialization/deserialization.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3202) Add DataInput/DataOutput subclasses
that delegate to an InputStream/OutputStream.
Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Weiss updated LUCENE-3202:
--------------------------------
Attachment: LUCENE-3202.patch
A patch moving these stream delegation classes to org.apache.lucene.store. A potential bug is piggybacked (potential partial read(byte[]) was not handled correctly).
> Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-3202
> URL: https://issues.apache.org/jira/browse/LUCENE-3202
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3202.patch
>
>
> Such classes would be handy for FST serialization/deserialization.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Issue Comment Edited] (LUCENE-3202) Add
DataInput/DataOutput subclasses that delegate to an
InputStream/OutputStream.
Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049104#comment-13049104 ]
Dawid Weiss edited comment on LUCENE-3202 at 6/14/11 10:25 AM:
---------------------------------------------------------------
A patch moving these stream delegation classes to org.apache.lucene.store. A potential bugfix is piggybacked (potential partial read(byte[]) was not handled correctly).
was (Author: dweiss):
A patch moving these stream delegation classes to org.apache.lucene.store. A potential bug is piggybacked (potential partial read(byte[]) was not handled correctly).
> Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-3202
> URL: https://issues.apache.org/jira/browse/LUCENE-3202
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3202.patch
>
>
> Such classes would be handy for FST serialization/deserialization.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3202) Add DataInput/DataOutput
subclasses that delegate to an InputStream/OutputStream.
Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049138#comment-13049138 ]
Shai Erera commented on LUCENE-3202:
------------------------------------
Patch looks good. Two comments:
# The files are missing the Apache License header.
# In some places you use this.is / this.out and others just is/out. Can you consolidate on one (I prefer w/o this.)?
> Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-3202
> URL: https://issues.apache.org/jira/browse/LUCENE-3202
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3202.patch
>
>
> Such classes would be handy for FST serialization/deserialization.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3202) Add DataInput/DataOutput
subclasses that delegate to an InputStream/OutputStream.
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049142#comment-13049142 ]
Robert Muir commented on LUCENE-3202:
-------------------------------------
I agree with moving these to .store package, sorry I forgot about this in the suggest refactoring.
I've had to write similar classes myself before since they were not there.
> Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-3202
> URL: https://issues.apache.org/jira/browse/LUCENE-3202
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3202.patch
>
>
> Such classes would be handy for FST serialization/deserialization.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-3202) Add DataInput/DataOutput subclasses
that delegate to an InputStream/OutputStream.
Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Weiss updated LUCENE-3202:
--------------------------------
Attachment: LUCENE-3202.patch
Updated patch, applied.
> Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-3202
> URL: https://issues.apache.org/jira/browse/LUCENE-3202
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3202.patch, LUCENE-3202.patch
>
>
> Such classes would be handy for FST serialization/deserialization.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-3202) Add DataInput/DataOutput subclasses
that delegate to an InputStream/OutputStream.
Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dawid Weiss resolved LUCENE-3202.
---------------------------------
Resolution: Fixed
> Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-3202
> URL: https://issues.apache.org/jira/browse/LUCENE-3202
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3202.patch, LUCENE-3202.patch
>
>
> Such classes would be handy for FST serialization/deserialization.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-3202) Add DataInput/DataOutput
subclasses that delegate to an InputStream/OutputStream.
Posted by "Dawid Weiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-3202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049146#comment-13049146 ]
Dawid Weiss commented on LUCENE-3202:
-------------------------------------
Thanks Shai. I'll add the headers, clean up this where applicable and commit in.
> Add DataInput/DataOutput subclasses that delegate to an InputStream/OutputStream.
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-3202
> URL: https://issues.apache.org/jira/browse/LUCENE-3202
> Project: Lucene - Java
> Issue Type: Task
> Components: core/other
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Trivial
> Fix For: 3.3, 4.0
>
> Attachments: LUCENE-3202.patch
>
>
> Such classes would be handy for FST serialization/deserialization.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org