You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pagespeed.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:44:14 UTC
[GitHub] [incubator-pagespeed-mod] oschaaf opened a new pull request #2017: Fix a bunch of build warnings
oschaaf opened a new pull request #2017:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2017
- Deprecation warnings from the new jsoncpp dep api usage
- Thread safety analysis
- Unused variables
- char as array index in base64 init call
Calling out the changes in redis_cache & rewrite_driver.cc/h
specifically as these seem rigth to me but are non-trivial.
Signed-off-by: Otto van der Schaaf <os...@we-amp.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf merged pull request #2017: Fix a bunch of build warnings
Posted by GitBox <gi...@apache.org>.
oschaaf merged pull request #2017:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf commented on pull request #2017: Fix a bunch of build warnings
Posted by GitBox <gi...@apache.org>.
oschaaf commented on pull request #2017:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2017#issuecomment-665326480
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-pagespeed-mod] oschaaf commented on pull request #2017: Fix a bunch of build warnings
Posted by GitBox <gi...@apache.org>.
oschaaf commented on pull request #2017:
URL: https://github.com/apache/incubator-pagespeed-mod/pull/2017#issuecomment-668578640
Filed https://github.com/apache/incubator-pagespeed-mod/issues/2025 as a leftover for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org