[GitHub] [hadoop] ahmarsuhail commented on a diff in pull request #5421: HADOOP-18565. Completes outstanding items for the SDK V2 upgrade.

["ahmarsuhail (via GitHub)" <gi...@apache.org>]

ahmarsuhail commented on code in PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#discussion_r1114152953


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AProxy.java:
##########
@@ -20,18 +20,17 @@
 
 import java.io.IOException;
 
-import com.amazonaws.ClientConfiguration;
-import com.amazonaws.Protocol;
 import org.assertj.core.api.Assertions;
 import org.junit.Test;
+import software.amazon.awssdk.http.apache.ProxyConfiguration;
 
 import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.s3a.impl.AWSClientConfig;
 import org.apache.hadoop.test.AbstractHadoopTestBase;
 
 import static org.apache.hadoop.fs.s3a.Constants.PROXY_HOST;
 import static org.apache.hadoop.fs.s3a.Constants.PROXY_PORT;
 import static org.apache.hadoop.fs.s3a.Constants.PROXY_SECURED;
-import static org.apache.hadoop.fs.s3a.S3AUtils.initProxySupport;
 
 /**

Review Comment:
   @mehakmeet I noticed we introduced a new config option `fs.s3a.proxy.ssl.enabled`, but the port of the proxy is still set using `fs.s3a.connection.ssl.enabled` [here](https://github.com/mehakmeet/hadoop/blob/8d7a7f74e62e4e37a91dc800cfbca698518ec37f/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AUtils.java#L1323). Was wondering why need the new `fs.s3a.proxy.ssl.enabled` option? can we not use `fs.s3a.connection.ssl.enabled` to set the protocol too? Asking here as this SDK V2 branch uses `fs.s3a.connection.ssl.enabled` to set both protocol + port, but that causes this test to fail as it uses `fs.s3a.proxy.ssl.enabled`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org