You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "Wes McKinney (Jira)" <ji...@apache.org> on 2020/05/25 20:26:00 UTC

[jira] [Commented] (ARROW-7822) [C++] Allocation free error Status constants

    [ https://issues.apache.org/jira/browse/ARROW-7822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17116243#comment-17116243 ] 

Wes McKinney commented on ARROW-7822:
-------------------------------------

I'm not sure that non-OK Status should ever be found on a performance hot path. That would indicate that Status is being used inappropriately for control flow. Unless I have misunderstood the issue?

> [C++] Allocation free error Status constants
> --------------------------------------------
>
>                 Key: ARROW-7822
>                 URL: https://issues.apache.org/jira/browse/ARROW-7822
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Ben Kietzman
>            Assignee: Ben Kietzman
>            Priority: Major
>
> {{Status::state_}} could be made a tagged pointer without affecting the fast path (passing around a non error status). The extra bit could be used to mark a Status' state as heap allocated or not, allowing very error statuses to be extremely cheap when their error state is known to be immutable. For example, this would allow a cheap default of {{Result<>::status_}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)