You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Cliff Jansen (JIRA)" <ji...@apache.org> on 2011/07/07 09:47:17 UTC
[jira] [Created] (QPID-3338) qpidxarm CMake target is missing in
0-12
qpidxarm CMake target is missing in 0-12
----------------------------------------
Key: QPID-3338
URL: https://issues.apache.org/jira/browse/QPID-3338
Project: Qpid
Issue Type: Bug
Components: C++ Broker, C++ Client
Affects Versions: 0.12
Environment: Windows with Microsoft compilers (as opposed to mingw)
Reporter: Cliff Jansen
Assignee: Cliff Jansen
Priority: Blocker
Fix For: 0.12
cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662).
The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable "WIN32".
This variable was changed to "_MSC_VER" for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately "_MSC_VER" is not a recognized CMAKE variable and the qpidxarm target is never generated.
The CMake documentation indicates the the variable "MSVC" should be used to indicate The Microsoft compiler compared to mingw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3338) qpidxarm CMake target is missing in
0-12
Posted by "Cliff Jansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064393#comment-13064393 ]
Cliff Jansen commented on QPID-3338:
------------------------------------
updated trunk: r1145883
updated 0.12 branch: r1145886
> qpidxarm CMake target is missing in 0-12
> ----------------------------------------
>
> Key: QPID-3338
> URL: https://issues.apache.org/jira/browse/QPID-3338
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: 0.12
> Environment: Windows with Microsoft compilers (as opposed to mingw)
> Reporter: Cliff Jansen
> Assignee: Cliff Jansen
> Priority: Blocker
> Fix For: 0.12
>
> Attachments: jira-3338.patch
>
>
> cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662).
> The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable "WIN32".
> This variable was changed to "_MSC_VER" for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately "_MSC_VER" is not a recognized CMAKE variable and the qpidxarm target is never generated.
> The CMake documentation indicates the the variable "MSVC" should be used to indicate The Microsoft compiler compared to mingw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3338) qpidxarm CMake target is missing in
0-12
Posted by "Cliff Jansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cliff Jansen updated QPID-3338:
-------------------------------
Attachment: jira-3338.patch
This patch applies the MSVC variable and works properly on my Windows box using Visual studio 9. I do not have a mingw setup and would appreciate if someone who does could apply the patch and verify that the patch has no unwanted side effects for them.
Thanks.
> qpidxarm CMake target is missing in 0-12
> ----------------------------------------
>
> Key: QPID-3338
> URL: https://issues.apache.org/jira/browse/QPID-3338
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: 0.12
> Environment: Windows with Microsoft compilers (as opposed to mingw)
> Reporter: Cliff Jansen
> Assignee: Cliff Jansen
> Priority: Blocker
> Fix For: 0.12
>
> Attachments: jira-3338.patch
>
>
> cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662).
> The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable "WIN32".
> This variable was changed to "_MSC_VER" for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately "_MSC_VER" is not a recognized CMAKE variable and the qpidxarm target is never generated.
> The CMake documentation indicates the the variable "MSVC" should be used to indicate The Microsoft compiler compared to mingw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3338) qpidxarm CMake target is missing in
0-12
Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064031#comment-13064031 ]
Justin Ross commented on QPID-3338:
-----------------------------------
Reviewed by Chuck Rolke on the dev list. Approved for 0.12.
> qpidxarm CMake target is missing in 0-12
> ----------------------------------------
>
> Key: QPID-3338
> URL: https://issues.apache.org/jira/browse/QPID-3338
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: 0.12
> Environment: Windows with Microsoft compilers (as opposed to mingw)
> Reporter: Cliff Jansen
> Assignee: Cliff Jansen
> Priority: Blocker
> Fix For: 0.12
>
> Attachments: jira-3338.patch
>
>
> cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662).
> The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable "WIN32".
> This variable was changed to "_MSC_VER" for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately "_MSC_VER" is not a recognized CMAKE variable and the qpidxarm target is never generated.
> The CMake documentation indicates the the variable "MSVC" should be used to indicate The Microsoft compiler compared to mingw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3338) qpidxarm CMake target is missing in
0-12
Posted by "Cliff Jansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064014#comment-13064014 ]
Cliff Jansen commented on QPID-3338:
------------------------------------
The patch tests fine on Fedora to generate makefiles via cmake
> qpidxarm CMake target is missing in 0-12
> ----------------------------------------
>
> Key: QPID-3338
> URL: https://issues.apache.org/jira/browse/QPID-3338
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: 0.12
> Environment: Windows with Microsoft compilers (as opposed to mingw)
> Reporter: Cliff Jansen
> Assignee: Cliff Jansen
> Priority: Blocker
> Fix For: 0.12
>
> Attachments: jira-3338.patch
>
>
> cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662).
> The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable "WIN32".
> This variable was changed to "_MSC_VER" for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately "_MSC_VER" is not a recognized CMAKE variable and the qpidxarm target is never generated.
> The CMake documentation indicates the the variable "MSVC" should be used to indicate The Microsoft compiler compared to mingw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3338) qpidxarm CMake target is missing in
0-12
Posted by "Cliff Jansen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Cliff Jansen resolved QPID-3338.
--------------------------------
Resolution: Fixed
> qpidxarm CMake target is missing in 0-12
> ----------------------------------------
>
> Key: QPID-3338
> URL: https://issues.apache.org/jira/browse/QPID-3338
> Project: Qpid
> Issue Type: Bug
> Components: C++ Broker, C++ Client
> Affects Versions: 0.12
> Environment: Windows with Microsoft compilers (as opposed to mingw)
> Reporter: Cliff Jansen
> Assignee: Cliff Jansen
> Priority: Blocker
> Fix For: 0.12
>
> Attachments: jira-3338.patch
>
>
> cpp/src/CMakeLists.txt was altered for mingw builds in QPID-2905 (r1104662).
> The qpidxarm target builds the XA distributed transaction resource manager for use with the Microsoft distributed trasanction coordinator. It was targeted for Windows builds only, using the CMake variable "WIN32".
> This variable was changed to "_MSC_VER" for QPID-2905, presumably to indicate that the build target should only apply to builds using the Microsoft compiler, and not mingw. Unfortunately "_MSC_VER" is not a recognized CMAKE variable and the qpidxarm target is never generated.
> The CMake documentation indicates the the variable "MSVC" should be used to indicate The Microsoft compiler compared to mingw.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org