You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/07/10 04:55:35 UTC
[GitHub] [lucene-solr] atris opened a new pull request #1662: Harden TestBuildingUpMemoryPressure
atris opened a new pull request #1662:
URL: https://github.com/apache/lucene-solr/pull/1662
1. Add specific checks for exception message expectation.
2. Ensure that a non triggering value is returned when the fake circuit breaker should not be tripping.
Also adds temporary logging for debugging, to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] atris merged pull request #1662: Harden TestBuildingUpMemoryPressure
Posted by GitBox <gi...@apache.org>.
atris merged pull request #1662:
URL: https://github.com/apache/lucene-solr/pull/1662
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] atris commented on pull request #1662: Harden TestBuildingUpMemoryPressure
Posted by GitBox <gi...@apache.org>.
atris commented on pull request #1662:
URL: https://github.com/apache/lucene-solr/pull/1662#issuecomment-656541978
Minimally invasive change -- should solve the test failure. I beasted this around 150 times with no failures and the counts do seem to match. Unless objections, I plan to merge this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org