[GitHub] carbondata pull request #2417: [CARBONDATA-2607][Complex Column Enhancements...

[gvramana <gi...@git.apache.org>]

Github user gvramana commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2417#discussion_r200927005
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/chunk/store/ColumnPageWrapper.java ---
    @@ -17,32 +17,39 @@
     
     package org.apache.carbondata.core.datastore.chunk.store;
     
    +
    +import org.apache.carbondata.core.constants.CarbonCommonConstants;
    +import org.apache.carbondata.core.datastore.ColumnType;
     import org.apache.carbondata.core.datastore.chunk.DimensionColumnPage;
     import org.apache.carbondata.core.datastore.page.ColumnPage;
    +import org.apache.carbondata.core.metadata.datatype.DataType;
    +import org.apache.carbondata.core.metadata.datatype.DataTypes;
     import org.apache.carbondata.core.scan.executor.infos.KeyStructureInfo;
     import org.apache.carbondata.core.scan.result.vector.ColumnVectorInfo;
    +import org.apache.carbondata.core.util.ByteUtil;
     
     public class ColumnPageWrapper implements DimensionColumnPage {
     
       private ColumnPage columnPage;
     
    -  public ColumnPageWrapper(ColumnPage columnPage) {
    +  private boolean isAdaptiveComplexPrimitivePage;
    +
    +  public ColumnPageWrapper(ColumnPage columnPage, boolean isAdaptiveComplexPrimitivePage) {
         this.columnPage = columnPage;
    +    this.isAdaptiveComplexPrimitivePage = isAdaptiveComplexPrimitivePage;
       }
     
       @Override
       public int fillRawData(int rowId, int offset, byte[] data, KeyStructureInfo restructuringInfo) {
         throw new UnsupportedOperationException("internal error");
       }
     
    -  @Override
    -  public int fillSurrogateKey(int rowId, int chunkIndex, int[] outputSurrogateKey,
    +  @Override public int fillSurrogateKey(int rowId, int chunkIndex, int[] outputSurrogateKey,
    --- End diff --
    
    Keep it same


---