You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/12/09 19:45:00 UTC
[GitHub] [incubator-nuttx] diegoherranz opened a new pull request #2508: drivers/leds/ws2812: optimize reset bytes
diegoherranz opened a new pull request #2508:
URL: https://github.com/apache/incubator-nuttx/pull/2508
## Summary
It's not necessary to send a reset pulse after sending the RGB data
since the first thing that a new transmission does is sending the long
reset pulse. I have left 1 reset byte after the RGB data to keep some
padding given that the bits inside the byte are shifted by 1 bit although
I think it wouldn't be necessary either. But just in case.
This reduces the memory usage (you can easily save 60 bytes) and increases
the maximum refresh rate.
## Impact
Just the ws2812 driver. Optimisation only.
## Testing
Tested on real LEDs and it works OK.
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2508: drivers/leds/ws2812: optimize reset bytes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2508:
URL: https://github.com/apache/incubator-nuttx/pull/2508
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org