[GitHub] [couchdb] awalterschulze edited a comment on pull request #3568: Reformat src files with erlfmt

[GitBox <gi...@apache.org>]

awalterschulze edited a comment on pull request #3568:
URL: https://github.com/apache/couchdb/pull/3568#issuecomment-853959096


   > > > As Paul's involuntary amanuensis he says "go for it" but asks if we've confirmed that the abstract syntax tree is unaffected (i.e, the changes are purely cosmetic and make no difference to the compiled artifacts).
   > > 
   > > 
   > > erlfmt verifies internally that the AST has not been modified, except for comments and code locations. If it is modified erlfmt would throw an error. If you find such cases, please report an error, so we can fix it.
   > 
   > @awalterschulze : does that mean the proof I do in https://github.com/apache/couchdb/pull/3568/files#diff-f2ea7984714072018b8a19daabd2dbc8df9f662af94849ffa7eb60b54bc711f0 is unnecessary and can be removed? Same thing for tests, we can run `erlfmt` on those files and they are guaranteed to be "identical"?
   
   erlfmt does it on the AST level, see https://github.com/WhatsApp/erlfmt/blob/master/src/erlfmt.erl#L459
   you seem to be doing it on the beam level.
   I think both have merit, but it depends how rigorous you need to be.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org