You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "DaanHoogland (via GitHub)" <gi...@apache.org> on 2024/11/07 14:12:56 UTC

Re: [PR] Restrict the migration of volumes attached to VMs in Starting state [cloudstack]

DaanHoogland commented on PR #9725:
URL: https://github.com/apache/cloudstack/pull/9725#issuecomment-2462341559

   > Is there any other state that we should be checking besides starting? migrating, for example?
   
   Good point, though this is already an improvement;
   ```
           Starting(true, "VM is being started.  At this state, you should find host id filled which means it's being started on that host."),
           Running(false, "VM is running.  host id has the host that it is running on."),
           Stopping(true, "VM is being stopped.  host id has the host that it is being stopped on."),
           Stopped(false, "VM is stopped.  host id should be null."),
           Destroyed(false, "VM is marked for destroy."),
           Expunging(true, "VM is being   expunged."),
           Migrating(true, "VM is being migrated.  host id holds to from host"),
           Error(false, "VM is in error"),
           Unknown(false, "VM state is unknown."),
           Shutdown(false, "VM state is shutdown from inside"),
           Restoring(true, "VM is being restored from backup");
   ```
   I think (at least) `Stopping`, `Destroyed`, `Expunging`, `Restoring` are good candidate `VirtualMachine.State`s to include. Or in reverse, only `Running`, `Stopped`, `Shutdown` and maybe `Error` or `Unknown` are good vm states to migrate volumes for.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org