You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/03/30 05:49:27 UTC

[GitHub] [pinot] KKcorps edited a comment on issue #8437: Support multiple response formats in Broker SQL API

KKcorps edited a comment on issue #8437:
URL: https://github.com/apache/pinot/issues/8437#issuecomment-1082646626


   It will look something like this - https://github.com/KKcorps/incubator-pinot/pull/1/files
   This is a very crude implementation and final PR should look really different from this.
   
   Things I do not like - 
   
   * Adding format dependencies to broker
   
   * Relying on reflections
   
   * Missing utility to generate avro/proto schema file for `BrokerResponseNative`
   
    
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org