[GitHub] [superset] kgabryje commented on a diff in pull request #20498: chore(explore): Update chart save to use API endpoints

[GitBox <gi...@apache.org>]

kgabryje commented on code in PR #20498:
URL: https://github.com/apache/superset/pull/20498#discussion_r917043602


##########
superset-frontend/src/explore/ExplorePage.tsx:
##########
@@ -16,50 +16,58 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React, { useEffect, useState } from 'react';
+import React, { useEffect, useRef, useState } from 'react';
 import { useDispatch } from 'react-redux';
+import { useLocation } from 'react-router-dom';
 import { makeApi, t } from '@superset-ui/core';
 import Loading from 'src/components/Loading';
+import { addDangerToast } from 'src/components/MessageToasts/actions';
+import { isNullish } from 'src/utils/common';

Review Comment:
   Yeah I wasn't aware of `isDefined`. Feel free to refactor 🙂 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org