You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/13 20:25:03 UTC
[GitHub] [airflow] andrewgodwin opened a new pull request #17610: Add cherry-pick notes to the release README
andrewgodwin opened a new pull request #17610:
URL: https://github.com/apache/airflow/pull/17610
This adds some more detail to the release README about the process of selecting what is in a release, including the fact that the release manager has some discretion about what to include based on severity, based on discussions with @ashb, @kaxil and @jhtimmins.
I suspect there's maybe some more detail needed here between "here's what to pick" and "here's how to roll the RC", but maybe not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #17610: Add cherry-pick notes to the release README
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #17610:
URL: https://github.com/apache/airflow/pull/17610#discussion_r688765496
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -47,6 +49,24 @@
You can find the prerequisites to release Apache Airflow in [README.md](README.md).
+# Selecting what to put into the release
+
+The first step of a release is to work out what is being included. This differs based on whether it is a major/minor or a patch release.
+
+- For a *major* or *minor* release, you want to include everything in `main` at the time of release; you'll turn this into a new release branch as part of the rest of the process.
+
+- For a *patch* release, you will be selecting specific commits to cherry-pick and backport into the existing release branch.
+
+## Selecting what to cherry-pick
+
+For obvious reasons, you can't cherry-pick every change from `main` into the release branch - some are incompatible without a large set of other changes, some are brand-new features, and some just don't need to be in a release.
+
+In general only security fixes, data-loss bugs and regression fixess are essential to bring into a patch release; other bugfixes can be added on a best-effort basis, but if something is going to be very difficult to backport (maybe it has a lot of conflicts, or heavily depends on a new feature or API that's not being backported), it's OK to leave it out.
Review comment:
```suggestion
In general only security fixes, data-loss bugs and regression fixess are essential to bring into a patch release; other bugfixes can be added on a best-effort basis, but if something is going to be very difficult to backport (maybe it has a lot of conflicts, or heavily depends on a new feature or API that's not being backported), it's OK to leave it out of the release at your sole discretion as the release manager. (If you do this update the milestone in the issue to the ” next" minor release.)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17610: Add cherry-pick notes to the release README
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17610:
URL: https://github.com/apache/airflow/pull/17610#issuecomment-898716305
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #17610: Add cherry-pick notes to the release README
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #17610:
URL: https://github.com/apache/airflow/pull/17610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org