[GitHub] rafaelweingartner commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons

[GitBox <gi...@apache.org>]

rafaelweingartner commented on issue #2431: CLOUDSTACK-10225: Deprecate StringUtils in favor of Apache Commons
URL: https://github.com/apache/cloudstack/pull/2431#issuecomment-361876348
 
 
   I disagree, but that is ok. Cascade/facade and others of the same type to these common libraries will cause more pain than benefits, and in my not so humble opinion will add code without value? There are other patterns one can use to reduce these types of problems you are mentioning. For instance, the logger upgrade, all you need is to change the log configuration, and then change the logger object, right? However, the logging methods will be maintained (info, debug, and so on). That would be easily done if instead of declaring a final static logger object in all classes, we used an inheritance strategy. Therefore, we would reduce greatly the surface of an upgrade like this one. The same applies when using other libraries that are used in a great number of objects. The problems we have with these upgrade is a consequence of poor design decisions in the past.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services