You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2023/01/11 01:22:31 UTC
[GitHub] [cordova-android] erisu opened a new pull request, #1538: feat!: bump target sdk & build tools for SDK 33 support
erisu opened a new pull request, #1538:
URL: https://github.com/apache/cordova-android/pull/1538
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Set latest Target SDK & Build Tools Version.
### Description
<!-- Describe your changes in detail -->
- Target SDK Version 33
- Minimum Build Tools Version 33.0.3
### Testing
<!-- Please describe in detail how you tested your changes. -->
n/a
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1538: feat!: bump target sdk & build tools for SDK 33 support
Posted by "jcesarmobile (via GitHub)" <gi...@apache.org>.
jcesarmobile commented on PR #1538:
URL: https://github.com/apache/cordova-android/pull/1538#issuecomment-1461836941
I don’t know, since it’s the minimum allowed maybe 33.0.0, but both 33.0.0 and 33.0.1 present bugs that were fixed in 33.0.2, so not sure if we should require 33.0.2 as minimum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1538: feat!: bump target sdk & build tools for SDK 33 support
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #1538:
URL: https://github.com/apache/cordova-android/pull/1538#issuecomment-1461708119
@jcesarmobile It seems that build tools `33.0.2` is out. Should I bump?
Or do you think it would be better to keep it as is or even lower the minimum to `33.0.0` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu merged pull request #1538: feat!: bump target sdk & build tools for SDK 33 support
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #1538:
URL: https://github.com/apache/cordova-android/pull/1538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1538: feat!: bump target sdk & build tools for SDK 33 support
Posted by "jcesarmobile (via GitHub)" <gi...@apache.org>.
jcesarmobile commented on PR #1538:
URL: https://github.com/apache/cordova-android/pull/1538#issuecomment-1462166731
no, they can't use an older version since this value is for the minimum version allowed and the code has a check that prevents from using older versions that the one we set there
but I'm ok making the minimum the latest at the moment of the release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] jcesarmobile commented on pull request #1538: feat!: bump target sdk & build tools for SDK 33 support
Posted by "jcesarmobile (via GitHub)" <gi...@apache.org>.
jcesarmobile commented on PR #1538:
URL: https://github.com/apache/cordova-android/pull/1538#issuecomment-1461792335
Probably
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] breautek commented on pull request #1538: feat!: bump target sdk & build tools for SDK 33 support
Posted by "breautek (via GitHub)" <gi...@apache.org>.
breautek commented on PR #1538:
URL: https://github.com/apache/cordova-android/pull/1538#issuecomment-1462136053
We generally discourage people from updating the build tools version unless absolutely necessary/know what they are doing so we probably should use the latest patch available, so that cordova by default will use the latest patch available (at the time of this PR) obviously.
33.0.1 resolves a compilation issue:
> AIDL fails with build-tools 33.0.0. (See [issue #236167971](https://issuetracker.google.com/issues/236167971))
It probably doesn't affect the cordova base but could affect other native libraries or third-party plugins.
33.0.2 addresses what appears to be a minor issue:
> core-lambda-stubs.jar version 33.0.0 differs on macOS versus Linux/Windows. (See [issue #237299698](https://issuetracker.google.com/issues/237299698).)
Nonetheless, I think we should just use the latest patch available, so that on release we can cleanly write an update guide stating they must have `33.0.2` installed, etc. It may save us having to explain that they need to set a preference to upgrade build tools to address `AIDL` issue if that issue affects them.
Just my own opinion. If they absolutely need to use 33.0.0 for some reason, I believe they can still set the `android-buildToolsVersion` themselves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] erisu commented on pull request #1538: feat!: bump target sdk & build tools for SDK 33 support
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu commented on PR #1538:
URL: https://github.com/apache/cordova-android/pull/1538#issuecomment-1461808923
> Probably
Which one you recommend?
-> 33.0.0
-> 33.0.1
-> 33.0.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-android] codecov-commenter commented on pull request #1538: feat!: bump target sdk & build tools for SDK 33 support
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1538:
URL: https://github.com/apache/cordova-android/pull/1538#issuecomment-1378142702
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1538?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1538](https://codecov.io/gh/apache/cordova-android/pull/1538?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d8d9bcc) into [master](https://codecov.io/gh/apache/cordova-android/commit/d02f8eafe8e34e33971c2e6dad2449cf1655ac99?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d02f8ea) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1538 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 21 21
Lines 1751 1751
=======================================
Hits 1263 1263
Misses 488 488
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org