[GitHub] [orc] dongjoon-hyun commented on a change in pull request #810: ORC-904: Optimize userMetadata data structure to avoid traversal

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #810:
URL: https://github.com/apache/orc/pull/810#discussion_r682099791



##########
File path: java/core/src/java/org/apache/orc/impl/ReaderImpl.java
##########
@@ -569,7 +561,13 @@ public ReaderImpl(Path path, OrcFile.ReaderOptions options) throws IOException {
       this.rowIndexStride = tail.getFooter().getRowIndexStride();
       this.contentLength = tail.getFooter().getContentLength();
       this.numberOfRows = tail.getFooter().getNumberOfRows();
-      this.userMetadata = tail.getFooter().getMetadataList();
+      this.userMetadata = tail.getFooter().getMetadataList()
+              .stream().collect(Collectors.toMap(

Review comment:
       If you don't mind, can we indent with `4-space` instead of `8-space`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org