You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/13 12:30:50 UTC

[GitHub] [ignite-3] SammyVimes commented on a change in pull request #92: IGNITE-14517 Fix ScaleCube's topology change handling

SammyVimes commented on a change in pull request #92:
URL: https://github.com/apache/ignite-3/pull/92#discussion_r612401184



##########
File path: modules/network/src/main/java/org/apache/ignite/network/scalecube/ScaleCubeTopologyService.java
##########
@@ -30,49 +32,62 @@
  * Implementation of {@link TopologyService} based on ScaleCube.
  */
 final class ScaleCubeTopologyService extends AbstractTopologyService {
-    /** Inner representation a ScaleCube cluster. */
-    private Cluster cluster;
+    /** Local member node. */
+    private ClusterNode localMember;
+
+    /** Topology members. */
+    private Map<String, ClusterNode> members = new HashMap<>();

Review comment:
       True, it should be




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org