You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/14 13:56:00 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #23182: Pass namespace through RunInference transform

damccorm commented on code in PR #23182:
URL: https://github.com/apache/beam/pull/23182#discussion_r970843223


##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -321,9 +324,10 @@ def expand(
         # TODO(https://github.com/apache/beam/issues/21440): Hook into the
         # batching DoFn APIs.
         | beam.BatchElements(**self._model_handler.batch_elements_kwargs())
-        | (
+        | 'RunInference_DoFn' >> (

Review Comment:
   If you'd prefer to follow up with those in another PR that's fine (your call), I'd just ask that this particular suggested change be made while we're here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org