You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "mingleizhang (JIRA)" <ji...@apache.org> on 2017/04/16 10:47:42 UTC
[jira] [Commented] (FLINK-6130) Consider calling
resourceManager#getTerminationFuture() with lock held
[ https://issues.apache.org/jira/browse/FLINK-6130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970332#comment-15970332 ]
mingleizhang commented on FLINK-6130:
-------------------------------------
[~tedyu] Thanks. I would ask how to use those return value that is stored from resouceManager#getTerminationFuture() or do nothing ? It seems there is a intersection with jira Flink-6275.
> Consider calling resourceManager#getTerminationFuture() with lock held
> ----------------------------------------------------------------------
>
> Key: FLINK-6130
> URL: https://issues.apache.org/jira/browse/FLINK-6130
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> In YarnFlinkApplicationMasterRunner#runApplicationMaster() :
> {code}
> synchronized (lock) {
> LOG.info("Starting High Availability Services");
> ...
> }
> // wait for resource manager to finish
> resourceManager.getTerminationFuture().get();
> {code}
> resourceManager#getTerminationFuture() is called without holding lock.
> We should store the value returned from resourceManager#getTerminationFuture() inside the synchronized block.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)