You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by anshul1886 <gi...@git.apache.org> on 2015/12/22 12:18:14 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/1274
CLOUDSTACK-9196: Fixing null pointer exception when vm meta data is synced on upgraded setup
https://issues.apache.org/jira/browse/CLOUDSTACK-9196
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anshul1886/cloudstack-1 CLOUDSTACK-9196
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1274
----
commit cbbec6f8e26b8a25a87aa0e841ad86cf6a8fe957
Author: Anshul Gangwar <an...@citrix.com>
Date: 2015-06-18T10:19:29Z
CLOUDSTACK-9196: Fixing null pointer exception when vm meta data is synced on
upgraded setup.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166910961
Shouldn't we log this information? Doesn't this mean that some resources could be freed up on the hypervisor?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1274
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-175834162
@bhaisaab @pdube @DaanHoogland @koushik-das lots of LGTM here , so great. but we don't know why you LGTM'd and as far as I know no tests were run...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by anshul1886 <gi...@git.apache.org>.
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-167040113
@pdube That part is handled elsewhere. Here we are concerned about syncing of VM metadata. So here if the VM is not in cloud DB then we are ignoring it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by anshul1886 <gi...@git.apache.org>.
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166799368
@DaanHoogland Updated the descrition
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166824866
Code changes LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-176055926
@runseb checked the diff, travis/jenkins passed, diff looked good to me.
I've merged this and few others without integration tests as they *don't* explictly need them; see the diff -- do you think an explicit integration test is necessary for this simple NPE check?
IMO, some changes cannot be tested by integration tests - if they are text related, in non-Java files such as READMEs, reset scripts (not even used by systemvm/systemvm.iso). Then, there are some changes such as this where we can cheat and avoid running integration tests given you know the code, and build/travis passes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-166611273
LGTM but please describe (preferable in a unit test) what situation is prevented from happening here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-175688521
LGTM, merging based on comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-167135604
Null check LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-9196: Fixing null pointer exce...
Posted by runseb <gi...@git.apache.org>.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-176108973
@bhaisaab actually I am not even seeing the travis runs here anymore.
Reason I am asking is genuine (again), because in the last few months Travis has shown to be flaky and was Green when actually tests did not run ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---