You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by br...@apache.org on 2013/11/18 08:41:08 UTC

svn commit: r1542934 - /continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java

Author: brett
Date: Mon Nov 18 07:41:08 2013
New Revision: 1542934

URL: http://svn.apache.org/r1542934
Log:
[CONTINUUM-2713] adjust tests for HTML changes

Modified:
    continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java

Modified: continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java
URL: http://svn.apache.org/viewvc/continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java?rev=1542934&r1=1542933&r2=1542934&view=diff
==============================================================================
--- continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java (original)
+++ continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java Mon Nov 18 07:41:08 2013
@@ -111,8 +111,7 @@ public abstract class AbstractPurgeTest
     {
         goToGeneralPurgePage();
         assertGeneralPurgePage();
-        clickLinkWithXPath(
-            "//preceding::input[@value='repository' and @type='hidden']//following::input[@type='submit']" );
+        clickLinkWithXPath( "//form[@name='addRepoPurgeConfig']/input[@type='submit']" );
         assertAddRepositoryPurgePage();
     }
 
@@ -160,9 +159,7 @@ public abstract class AbstractPurgeTest
     protected void goToAddDirectoryPurge()
     {
         goToGeneralPurgePage();
-        assertGeneralPurgePage();
-        clickLinkWithXPath(
-            "//preceding::input[@value='directory' and @type='hidden']//following::input[@type='submit']" );
+        clickLinkWithXPath( "//form[@name='addDirPurgeConfig']/input[@type='submit']" );
         assertAddEditDirectoryPurgePage();
     }

Re: svn commit: r1542934 - /continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java

Posted by Brett Porter <br...@apache.org>.

Brent Atkinson wrote:
> Hi Brett,
>
> I am new to review via the commit list. If I am doing things that I can
> improve upon, don't be shy to critique. I will consider the correction a
> high compliment.

Thanks for taking a look!

>
>
> @@ -160,9 +159,7 @@ public abstract class AbstractPurgeTest
>>       protected void goToAddDirectoryPurge()
>>       {
>>           goToGeneralPurgePage();
>> -        assertGeneralPurgePage();
>>
>
> Is there a reason that the assert was removed here and not in the other
> method?

Seems I missed that - I'll remove them now.

Cheers,
Brett

Re: svn commit: r1542934 - /continuum/branches/CONTINUUM-2713/continuum-webapp-test/src/test/testng/org/apache/continuum/web/test/parent/AbstractPurgeTest.java

Posted by Brent Atkinson <br...@gmail.com>.
Hi Brett,

I am new to review via the commit list. If I am doing things that I can
improve upon, don't be shy to critique. I will consider the correction a
high compliment.


@@ -160,9 +159,7 @@ public abstract class AbstractPurgeTest
>      protected void goToAddDirectoryPurge()
>      {
>          goToGeneralPurgePage();
> -        assertGeneralPurgePage();
>

Is there a reason that the assert was removed here and not in the other
method?


> -        clickLinkWithXPath(
> -            "//preceding::input[@value='directory' and
> @type='hidden']//following::input[@type='submit']" );
> +        clickLinkWithXPath(
> "//form[@name='addDirPurgeConfig']/input[@type='submit']" );
>          assertAddEditDirectoryPurgePage();
>      }
>