You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Patil <pr...@gmail.com> on 2024/02/11 11:58:42 UTC
Review Request 74867: RANGER-4696: Fix User Deletion Issue for GDS approver users in Ranger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74867/
-----------------------------------------------------------
Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.
Bugs: RANGER-4696
https://issues.apache.org/jira/browse/RANGER-4696
Repository: ranger
Description
-------
Currently, there is a user deletion issue in Ranger where if a user is an approver for any of the GDSDataShareInDataset or GDSDataSetInProject objects, the deletion process encounters errors.
Solution : On user deletion update the approver Id to Ranger Admin Id wherever the deleted user is an approver.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java 0ced5565b
Diff: https://reviews.apache.org/r/74867/diff/1/
Testing
-------
1. Created an admin user admin_2 and assigned permissions on GDS module
2. Created a dataset and a datashare, and created a request to add datashare in dataset
3. As admin_2 user, approved the request
4. As admin user, deleted the admin_2 user from Ranger admin. The deletion was successful.
Thanks,
Abhishek Patil
Re: Review Request 74867: RANGER-4696: Fix User Deletion Issue for GDS approver users in Ranger
Posted by Anand Nadar <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74867/#review226211
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Nadar
On Feb. 11, 2024, 11:58 a.m., Abhishek Patil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74867/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2024, 11:58 a.m.)
>
>
> Review request for ranger, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, and Ramesh Mani.
>
>
> Bugs: RANGER-4696
> https://issues.apache.org/jira/browse/RANGER-4696
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Currently, there is a user deletion issue in Ranger where if a user is an approver for any of the GDSDataShareInDataset or GDSDataSetInProject objects, the deletion process encounters errors.
>
> Solution : On user deletion update the approver Id to Ranger Admin Id wherever the deleted user is an approver.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/XPortalUserService.java 0ced5565b
>
>
> Diff: https://reviews.apache.org/r/74867/diff/1/
>
>
> Testing
> -------
>
> 1. Created an admin user admin_2 and assigned permissions on GDS module
> 2. Created a dataset and a datashare, and created a request to add datashare in dataset
> 3. As admin_2 user, approved the request
> 4. As admin user, deleted the admin_2 user from Ranger admin. The deletion was successful.
>
>
> Thanks,
>
> Abhishek Patil
>
>