You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/05/09 23:26:03 UTC

[jira] [Commented] (QPID-3252) Regression: broker no longer explicitly flushes messages to store on execution.sync or when sync command bit set.

    [ https://issues.apache.org/jira/browse/QPID-3252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030903#comment-13030903 ] 

jiraposter@reviews.apache.org commented on QPID-3252:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/701/
-----------------------------------------------------------

Review request for qpid, Alan Conway, Gordon Sim, and Kim van der Riet.


Summary
-------

Broker now issues an explicit flush for each received message that has the sync flag set in the message.transfer command.
Broker also tracks all messages received that do _not_ have the sync flag set, and will flush these messages on receipt of an execution.sync.


This addresses bug QPID-3252.
    https://issues.apache.org/jira/browse/QPID-3252


Diffs
-----

  /trunk/qpid/cpp/src/qpid/broker/SessionState.h 1101206 
  /trunk/qpid/cpp/src/qpid/broker/SessionState.cpp 1101206 

Diff: https://reviews.apache.org/r/701/diff


Testing
-------

qpid unit & store unit


Thanks,

Kenneth



> Regression: broker no longer explicitly flushes messages to store on execution.sync or when sync command bit set.
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-3252
>                 URL: https://issues.apache.org/jira/browse/QPID-3252
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.10
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>             Fix For: 0.11
>
>
> In the previous release of the broker, an execution.sync command, or a message.transfer command with a sync flag would cause the broker to explicitly flush the message(s) and pend until the flushes complete.  In the new asynchronous model, the broker does not initiate a flush under these scenarios.  Without explicitly flushing, the completion of a message.transfer/execution.sync may delay for an unacceptable amount of time (ex. 1sec+) when used with store.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org