You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/05/26 06:05:14 UTC
[GitHub] [libcloud] micafer opened a new pull request #1586: Enable to get Volume Quota details in OpenStack driver
micafer opened a new pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586
## Enable to get Volume Quota details in OpenStack driver
### Description
Implements #1585
### Status
- done, ready for review
### Checklist (tick everything that applies)
- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
- [ ] Documentation
- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
- [x] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] vdloo commented on pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
vdloo commented on pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#issuecomment-939989564
looks like:
```
In [4]: conn.ex_get_volume_quotas('ab031u84abc34ac0c45ab7123eb36fab')
Out[4]: <OpenStack_2_VolumeQuota Volumes="<OpenStack_2_QuotaSetItem in_use="476", limit="1000",reserved="0">", gigabytes="<OpenStack_2_QuotaSetItem in_use="8080", limit="10000",reserved="0">", snapshots="<OpenStack_2_QuotaSetItem in_use="73", limit="100",reserved="0">", backups="<OpenStack_2_QuotaSetItem in_use="0", limit="10",reserved="0">">
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#issuecomment-848496298
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1586](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c9f9fb2) into [trunk](https://codecov.io/gh/apache/libcloud/commit/ea364c58cd954d6b076c4e30bb283f33381a1246?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea364c5) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.52%`.
[](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1586 +/- ##
==========================================
- Coverage 83.01% 83.00% -0.01%
==========================================
Files 394 394
Lines 84999 85033 +34
Branches 9040 9045 +5
==========================================
+ Hits 70558 70583 +25
- Misses 11374 11379 +5
- Partials 3067 3071 +4
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `85.54% <68.00%> (-0.34%)` | :arrow_down: |
| [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.43% <88.88%> (-0.03%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ea364c5...c9f9fb2](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] vdloo commented on a change in pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
vdloo commented on a change in pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#discussion_r726076426
##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -4010,12 +4010,37 @@ def ex_get_network_quotas(self, project_id):
:param project_id: The ID of the project.
:type project_id: ``str``
- :rtype: :class:`OpenStack_2_QuotaSet`
+ :rtype: :class:`OpenStack_2_NetworkQuota`
"""
url = '/v2.0/quotas/%s/details.json' % project_id
return self._to_network_quota(
self.network_connection.request(url).object['quota'])
+ def _to_volume_quota(self, obj):
+ res = OpenStack_2_VolumeQuota(
+ backup_gigabytes=obj.get('backup_gigabytes', None),
+ gigabytes=obj.get('gigabytes', None),
+ per_volume_gigabytes=obj.get('per_volume_gigabytes', None),
+ backups=obj.get('backups', None),
+ snapshots=obj.get('snapshots', None),
+ volumes=obj.get('volumes', None),
+ driver=self.connection.driver)
+
+ return res
+
+ def ex_get_volume_quotas(self, project_id):
Review comment:
perhaps it would be nice to use the project_id of the API connection by default (making project_id an optional argument)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] micafer commented on a change in pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
micafer commented on a change in pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#discussion_r726153913
##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -4010,12 +4010,37 @@ def ex_get_network_quotas(self, project_id):
:param project_id: The ID of the project.
:type project_id: ``str``
- :rtype: :class:`OpenStack_2_QuotaSet`
+ :rtype: :class:`OpenStack_2_NetworkQuota`
"""
url = '/v2.0/quotas/%s/details.json' % project_id
return self._to_network_quota(
self.network_connection.request(url).object['quota'])
+ def _to_volume_quota(self, obj):
+ res = OpenStack_2_VolumeQuota(
+ backup_gigabytes=obj.get('backup_gigabytes', None),
+ gigabytes=obj.get('gigabytes', None),
+ per_volume_gigabytes=obj.get('per_volume_gigabytes', None),
+ backups=obj.get('backups', None),
+ snapshots=obj.get('snapshots', None),
+ volumes=obj.get('volumes', None),
+ driver=self.connection.driver)
+
+ return res
+
+ def ex_get_volume_quotas(self, project_id):
Review comment:
Where is the best way to get it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] vdloo commented on a change in pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
vdloo commented on a change in pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#discussion_r726183069
##########
File path: libcloud/compute/drivers/openstack.py
##########
@@ -4010,12 +4010,37 @@ def ex_get_network_quotas(self, project_id):
:param project_id: The ID of the project.
:type project_id: ``str``
- :rtype: :class:`OpenStack_2_QuotaSet`
+ :rtype: :class:`OpenStack_2_NetworkQuota`
"""
url = '/v2.0/quotas/%s/details.json' % project_id
return self._to_network_quota(
self.network_connection.request(url).object['quota'])
+ def _to_volume_quota(self, obj):
+ res = OpenStack_2_VolumeQuota(
+ backup_gigabytes=obj.get('backup_gigabytes', None),
+ gigabytes=obj.get('gigabytes', None),
+ per_volume_gigabytes=obj.get('per_volume_gigabytes', None),
+ backups=obj.get('backups', None),
+ snapshots=obj.get('snapshots', None),
+ volumes=obj.get('volumes', None),
+ driver=self.connection.driver)
+
+ return res
+
+ def ex_get_volume_quotas(self, project_id):
Review comment:
don't know, perhaps this thing here could save it on the connection object or something: https://github.com/apache/libcloud/blob/cc5987b5f79d4bca9c9139f24878686224b75425/libcloud/common/openstack_identity.py#L1446 don't think currently that information is available
anyway that could be something for a later PR, I don't find that blocking for this one. would just be a nice to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#issuecomment-848496298
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1586](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c9f9fb2) into [trunk](https://codecov.io/gh/apache/libcloud/commit/ea364c58cd954d6b076c4e30bb283f33381a1246?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea364c5) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.52%`.
[](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1586 +/- ##
==========================================
- Coverage 83.01% 83.00% -0.01%
==========================================
Files 394 394
Lines 84999 85033 +34
Branches 9040 9045 +5
==========================================
+ Hits 70558 70583 +25
- Misses 11374 11379 +5
- Partials 3067 3071 +4
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `85.54% <68.00%> (-0.34%)` | :arrow_down: |
| [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.43% <88.88%> (-0.03%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ea364c5...c9f9fb2](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] vdloo commented on a change in pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
vdloo commented on a change in pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#discussion_r726075833
##########
File path: libcloud/test/compute/fixtures/openstack_v1.1/_v3_0__volume_quota.json
##########
@@ -0,0 +1,55 @@
+{
+ "quota_set": {
+ "backup_gigabytes": {
+ "in_use": 0,
+ "limit": 1000,
+ "reserved": 0
+ },
+ "backups": {
+ "in_use": 0,
+ "limit": 10,
+ "reserved": 0
+ },
+ "gigabytes": {
+ "in_use": 10,
+ "limit": 1000,
+ "reserved": 0
+ },
+ "gigabytes___DEFAULT__": {
+ "in_use": 0,
+ "limit": -1,
+ "reserved": 0
+ },
+ "groups": {
+ "in_use": 0,
+ "limit": 10,
+ "reserved": 0
+ },
+ "id": "fake_tenant",
+ "per_volume_gigabytes": {
+ "in_use": 0,
+ "limit": -1,
+ "reserved": 0
+ },
+ "snapshots": {
+ "in_use": 0,
+ "limit": 10,
+ "reserved": 0
+ },
+ "snapshots___DEFAULT__": {
+ "in_use": 0,
+ "limit": -1,
+ "reserved": 0
+ },
+ "volumes": {
+ "in_use": 0,
+ "limit": 10,
+ "reserved": 0
+ },
+ "volumes___DEFAULT__": {
+ "in_use": 0,
+ "limit": -1,
+ "reserved": 0
+ }
+ }
+}
Review comment:
missing newline at end of file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter commented on pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#issuecomment-848496298
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1586](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b08e67a) into [trunk](https://codecov.io/gh/apache/libcloud/commit/ea364c58cd954d6b076c4e30bb283f33381a1246?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ea364c5) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.52%`.
[](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1586 +/- ##
==========================================
- Coverage 83.01% 83.00% -0.01%
==========================================
Files 394 394
Lines 84999 85033 +34
Branches 9040 9045 +5
==========================================
+ Hits 70558 70583 +25
- Misses 11374 11379 +5
- Partials 3067 3071 +4
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `85.54% <68.00%> (-0.34%)` | :arrow_down: |
| [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.43% <88.88%> (-0.03%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [ea364c5...b08e67a](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] micafer commented on pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
micafer commented on pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#issuecomment-939865597
@Kami this PR is here for a long time, can anybody review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] Kami merged pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
Kami merged pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [libcloud] codecov-commenter edited a comment on pull request #1586: Enable to get Volume Quota details in OpenStack driver
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1586:
URL: https://github.com/apache/libcloud/pull/1586#issuecomment-848496298
# [Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1586](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cf63133) into [trunk](https://codecov.io/gh/apache/libcloud/commit/e06fb47f01622b86fd4500cc843b98ebdcf9beed?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e06fb47) will **decrease** coverage by `0.00%`.
> The diff coverage is `73.52%`.
[](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## trunk #1586 +/- ##
==========================================
- Coverage 83.02% 83.02% -0.01%
==========================================
Files 394 394
Lines 85034 85068 +34
Branches 9041 9046 +5
==========================================
+ Hits 70600 70625 +25
- Misses 11365 11370 +5
- Partials 3069 3073 +4
```
| [Impacted Files](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [libcloud/compute/drivers/openstack.py](https://codecov.io/gh/apache/libcloud/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvY29tcHV0ZS9kcml2ZXJzL29wZW5zdGFjay5weQ==) | `85.55% <68.00%> (-0.34%)` | :arrow_down: |
| [libcloud/test/compute/test\_openstack.py](https://codecov.io/gh/apache/libcloud/pull/1586/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGliY2xvdWQvdGVzdC9jb21wdXRlL3Rlc3Rfb3BlbnN0YWNrLnB5) | `94.43% <88.88%> (-0.03%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e06fb47...cf63133](https://codecov.io/gh/apache/libcloud/pull/1586?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org