You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by pubudu538 <gi...@git.apache.org> on 2015/05/27 13:03:44 UTC
[GitHub] stratos pull request: Fixed issues in network partition remove
GitHub user pubudu538 opened a pull request:
https://github.com/apache/stratos/pull/362
Fixed issues in network partition remove
Fixed removing network partition when used in deployment policy and application policy
validate partition id in network partition
changed samples to undeploy network partitions after removing application policies and deployment policies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pubudu538/stratos rctesting
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/362.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #362
----
commit b2fcbf7442fe98f24d2482e833796ef7a1b4b8b2
Author: Pubudu Gunatilaka <pu...@gmail.com>
Date: 2015-05-27T10:58:20Z
Fixed issues in network partition remove
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] stratos pull request: Fixed issues in network partition remove
Posted by pubudu538 <gi...@git.apache.org>.
Github user pubudu538 closed the pull request at:
https://github.com/apache/stratos/pull/362
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] stratos pull request: Fixed issues in network partition remove
Posted by Lahiru Sandaruwan <la...@wso2.com>.
Hi Pubudu,
I have merged the pull request.
Thanks.
On Wed, May 27, 2015 at 7:17 PM, Rajkumar Rajaratnam <ra...@wso2.com>
wrote:
> Thanks a lot Pubudu!
>
> I reviewed it - it is a cleaner solution now.
>
>
> On Wed, May 27, 2015 at 6:33 PM, Pubudu Gunatilaka <pu...@wso2.com>
> wrote:
>
>> I changed the files and committed to the same branch. Please review and
>> merge.
>>
>> Thank you!
>>
>> On Wed, May 27, 2015 at 4:53 PM, Pubudu Gunatilaka <pu...@wso2.com>
>> wrote:
>>
>>> The requirement here was to get deployment policies and applications
>>> policies. I will change this to be done at Stratos Manager so that there
>>> won't be any calls from CC to AS.
>>>
>>> Thank you!
>>>
>>> On Wed, May 27, 2015 at 4:40 PM, R-Rajkumar <gi...@git.apache.org> wrote:
>>>
>>>> Github user R-Rajkumar commented on a diff in the pull request:
>>>>
>>>> https://github.com/apache/stratos/pull/362#discussion_r31122756
>>>>
>>>> --- Diff:
>>>> components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/services/impl/CloudControllerServiceImpl.java
>>>> ---
>>>> @@ -1524,6 +1529,53 @@ public boolean removeNetworkPartition(String
>>>> networkPartitionId) throws NetworkP
>>>> return true;
>>>> }
>>>>
>>>> + private void validateNetworkPartition(String
>>>> networkPartitionId) {
>>>> +
>>>> + try {
>>>> + DeploymentPolicy[] deploymentPolicies =
>>>> AutoscalerServiceClient.getInstance().getDeploymentPolicies();
>>>> +
>>>> --- End diff --
>>>>
>>>> We shouldn't call AS service from CC
>>>>
>>>>
>>>> ---
>>>> If your project is set up for it, you can reply to this email and have
>>>> your
>>>> reply appear on GitHub as well. If your project does not have this
>>>> feature
>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>> please
>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>> ticket
>>>> with INFRA.
>>>> ---
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> *Pubudu Gunatilaka*
>>> Software Engineer
>>> WSO2, Inc.: http://wso2.com
>>> lean.enterprise.middleware
>>> mobile: +94 77 4078049
>>>
>>
>>
>>
>> --
>>
>> *Pubudu Gunatilaka*
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean.enterprise.middleware
>> mobile: +94 77 4078049
>>
>
>
>
> --
> Rajkumar Rajaratnam
> Committer & PMC Member, Apache Stratos
> Software Engineer, WSO2
>
> Mobile : +94777568639
> Blog : rajkumarr.com
>
--
--
Lahiru Sandaruwan
Committer and PMC member, Apache Stratos,
Senior Software Engineer,
WSO2 Inc., http://wso2.com
lean.enterprise.middleware
phone: +94773325954
email: lahirus@wso2.com blog: http://lahiruwrites.blogspot.com/
linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146
Re: [GitHub] stratos pull request: Fixed issues in network partition remove
Posted by Rajkumar Rajaratnam <ra...@wso2.com>.
Thanks a lot Pubudu!
I reviewed it - it is a cleaner solution now.
On Wed, May 27, 2015 at 6:33 PM, Pubudu Gunatilaka <pu...@wso2.com> wrote:
> I changed the files and committed to the same branch. Please review and
> merge.
>
> Thank you!
>
> On Wed, May 27, 2015 at 4:53 PM, Pubudu Gunatilaka <pu...@wso2.com>
> wrote:
>
>> The requirement here was to get deployment policies and applications
>> policies. I will change this to be done at Stratos Manager so that there
>> won't be any calls from CC to AS.
>>
>> Thank you!
>>
>> On Wed, May 27, 2015 at 4:40 PM, R-Rajkumar <gi...@git.apache.org> wrote:
>>
>>> Github user R-Rajkumar commented on a diff in the pull request:
>>>
>>> https://github.com/apache/stratos/pull/362#discussion_r31122756
>>>
>>> --- Diff:
>>> components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/services/impl/CloudControllerServiceImpl.java
>>> ---
>>> @@ -1524,6 +1529,53 @@ public boolean removeNetworkPartition(String
>>> networkPartitionId) throws NetworkP
>>> return true;
>>> }
>>>
>>> + private void validateNetworkPartition(String
>>> networkPartitionId) {
>>> +
>>> + try {
>>> + DeploymentPolicy[] deploymentPolicies =
>>> AutoscalerServiceClient.getInstance().getDeploymentPolicies();
>>> +
>>> --- End diff --
>>>
>>> We shouldn't call AS service from CC
>>>
>>>
>>> ---
>>> If your project is set up for it, you can reply to this email and have
>>> your
>>> reply appear on GitHub as well. If your project does not have this
>>> feature
>>> enabled and wishes so, or if the feature is enabled but not working,
>>> please
>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>> ticket
>>> with INFRA.
>>> ---
>>>
>>
>>
>>
>> --
>>
>> *Pubudu Gunatilaka*
>> Software Engineer
>> WSO2, Inc.: http://wso2.com
>> lean.enterprise.middleware
>> mobile: +94 77 4078049
>>
>
>
>
> --
>
> *Pubudu Gunatilaka*
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean.enterprise.middleware
> mobile: +94 77 4078049
>
--
Rajkumar Rajaratnam
Committer & PMC Member, Apache Stratos
Software Engineer, WSO2
Mobile : +94777568639
Blog : rajkumarr.com
Re: [GitHub] stratos pull request: Fixed issues in network partition remove
Posted by Pubudu Gunatilaka <pu...@wso2.com>.
I changed the files and committed to the same branch. Please review and
merge.
Thank you!
On Wed, May 27, 2015 at 4:53 PM, Pubudu Gunatilaka <pu...@wso2.com> wrote:
> The requirement here was to get deployment policies and applications
> policies. I will change this to be done at Stratos Manager so that there
> won't be any calls from CC to AS.
>
> Thank you!
>
> On Wed, May 27, 2015 at 4:40 PM, R-Rajkumar <gi...@git.apache.org> wrote:
>
>> Github user R-Rajkumar commented on a diff in the pull request:
>>
>> https://github.com/apache/stratos/pull/362#discussion_r31122756
>>
>> --- Diff:
>> components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/services/impl/CloudControllerServiceImpl.java
>> ---
>> @@ -1524,6 +1529,53 @@ public boolean removeNetworkPartition(String
>> networkPartitionId) throws NetworkP
>> return true;
>> }
>>
>> + private void validateNetworkPartition(String networkPartitionId)
>> {
>> +
>> + try {
>> + DeploymentPolicy[] deploymentPolicies =
>> AutoscalerServiceClient.getInstance().getDeploymentPolicies();
>> +
>> --- End diff --
>>
>> We shouldn't call AS service from CC
>>
>>
>> ---
>> If your project is set up for it, you can reply to this email and have
>> your
>> reply appear on GitHub as well. If your project does not have this feature
>> enabled and wishes so, or if the feature is enabled but not working,
>> please
>> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
>> with INFRA.
>> ---
>>
>
>
>
> --
>
> *Pubudu Gunatilaka*
> Software Engineer
> WSO2, Inc.: http://wso2.com
> lean.enterprise.middleware
> mobile: +94 77 4078049
>
--
*Pubudu Gunatilaka*
Software Engineer
WSO2, Inc.: http://wso2.com
lean.enterprise.middleware
mobile: +94 77 4078049
Re: [GitHub] stratos pull request: Fixed issues in network partition remove
Posted by Pubudu Gunatilaka <pu...@wso2.com>.
The requirement here was to get deployment policies and applications
policies. I will change this to be done at Stratos Manager so that there
won't be any calls from CC to AS.
Thank you!
On Wed, May 27, 2015 at 4:40 PM, R-Rajkumar <gi...@git.apache.org> wrote:
> Github user R-Rajkumar commented on a diff in the pull request:
>
> https://github.com/apache/stratos/pull/362#discussion_r31122756
>
> --- Diff:
> components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/services/impl/CloudControllerServiceImpl.java
> ---
> @@ -1524,6 +1529,53 @@ public boolean removeNetworkPartition(String
> networkPartitionId) throws NetworkP
> return true;
> }
>
> + private void validateNetworkPartition(String networkPartitionId) {
> +
> + try {
> + DeploymentPolicy[] deploymentPolicies =
> AutoscalerServiceClient.getInstance().getDeploymentPolicies();
> +
> --- End diff --
>
> We shouldn't call AS service from CC
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
*Pubudu Gunatilaka*
Software Engineer
WSO2, Inc.: http://wso2.com
lean.enterprise.middleware
mobile: +94 77 4078049
[GitHub] stratos pull request: Fixed issues in network partition remove
Posted by R-Rajkumar <gi...@git.apache.org>.
Github user R-Rajkumar commented on a diff in the pull request:
https://github.com/apache/stratos/pull/362#discussion_r31122756
--- Diff: components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/services/impl/CloudControllerServiceImpl.java ---
@@ -1524,6 +1529,53 @@ public boolean removeNetworkPartition(String networkPartitionId) throws NetworkP
return true;
}
+ private void validateNetworkPartition(String networkPartitionId) {
+
+ try {
+ DeploymentPolicy[] deploymentPolicies = AutoscalerServiceClient.getInstance().getDeploymentPolicies();
+
--- End diff --
We shouldn't call AS service from CC
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] stratos pull request: Fixed issues in network partition remove
Posted by Rajkumar Rajaratnam <ra...@wso2.com>.
Hi Pubudu,
Are you calling AS service from CC? We shouldn't do that. The communication
should be from AS to CC, not CC to AS.
Thanks.
On Wed, May 27, 2015 at 4:33 PM, pubudu538 <gi...@git.apache.org> wrote:
> GitHub user pubudu538 opened a pull request:
>
> https://github.com/apache/stratos/pull/362
>
> Fixed issues in network partition remove
>
> Fixed removing network partition when used in deployment policy and
> application policy
> validate partition id in network partition
> changed samples to undeploy network partitions after removing
> application policies and deployment policies
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/pubudu538/stratos rctesting
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/stratos/pull/362.patch
>
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #362
>
> ----
> commit b2fcbf7442fe98f24d2482e833796ef7a1b4b8b2
> Author: Pubudu Gunatilaka <pu...@gmail.com>
> Date: 2015-05-27T10:58:20Z
>
> Fixed issues in network partition remove
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
--
Rajkumar Rajaratnam
Committer & PMC Member, Apache Stratos
Software Engineer, WSO2
Mobile : +94777568639
Blog : rajkumarr.com