You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "0yukali0 (via GitHub)" <gi...@apache.org> on 2023/05/10 05:11:57 UTC

[GitHub] [yunikorn-web] 0yukali0 opened a new pull request, #112: [YUNIKORN-1638] Updating REST API in the json-db

0yukali0 opened a new pull request, #112:
URL: https://github.com/apache/yunikorn-web/pull/112

   ### What is this PR for?
   The format of current some data in the json-server is not consistent to the REST API in the latest Yunikorn  version.
   
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   * [x] - Task
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-1638
   
   ### How should this be tested?
   run `make json-server` and curl related URLs.
   ```
     Resources
     http://localhost:9889/clusters
     http://localhost:9889/queues
     http://localhost:9889/apps
     http://localhost:9889/appHistory
     http://localhost:9889/containerHistory
     http://localhost:9889/nodes
     http://localhost:9889/partitions
   
     Other routes
     /ws/v1/* -> /$1
     /history/apps -> /appHistory
     /history/containers -> /containerHistory
     /partition/:partition/queues -> /queues
     /partition/:partition/nodes -> /nodes
     /partition/:partition/queue/:queue/applications -> /apps
   ```
   or run the `make start-dev` in the web rep.
   web UI will receive the responses from the json server and show the data.
   
   ### Screenshots (if appropriate)
   <img width="1487" alt="image" src="https://github.com/apache/yunikorn-web/assets/45888688/70187741-28b7-4dd8-9085-f64e058762b9">
   <img width="1487" alt="image" src="https://github.com/apache/yunikorn-web/assets/45888688/4418a521-615e-4aff-a6ae-76d07c5ea6f7">
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-web] 0yukali0 closed pull request #112: [YUNIKORN-1638] Updating REST API in the json-db

Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 closed pull request #112: [YUNIKORN-1638] Updating REST API in the json-db
URL: https://github.com/apache/yunikorn-web/pull/112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-web] 0yukali0 commented on pull request #112: [YUNIKORN-1638] Updating REST API in the json-db

Posted by "0yukali0 (via GitHub)" <gi...@apache.org>.
0yukali0 commented on PR #112:
URL: https://github.com/apache/yunikorn-web/pull/112#issuecomment-1541368607

   There are conflict problems, I will reopen this PR when I fix the problems locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org