[jira] [Created] (YARN-10019) container-executor: misc improvements in child process and regarding exec() calls

["Peter Bacsko (Jira)" <ji...@apache.org>]

Peter Bacsko created YARN-10019:
-----------------------------------

             Summary: container-executor: misc improvements in child process and regarding exec() calls
                 Key: YARN-10019
                 URL: https://issues.apache.org/jira/browse/YARN-10019
             Project: Hadoop YARN
          Issue Type: Bug
          Components: nodemanager
            Reporter: Peter Bacsko
            Assignee: Peter Bacsko


There are a couple of improvements that we can do in container-executor regarding how we exit from child processes and how we handle failed exec() calls:

1. If we're in the child code path and we detect an erroneous condition, the usual way is just simply call {{_exit()}}. Normal {{exit()}} occurs in the parent. Calling {{_exit()}}  prevents flushing stdio buffers twice and any cleanup logic registered with {{atexit()}} or {{on_exit()}} will run only once.

2. There's code like {{if (execlp(script_file_dest, script_file_dest, NULL) != 0) ...}} which is not necessary. Exec functions are not supposed to return. If they do, it's definitely an error, so no need to check the return value.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-dev-help@hadoop.apache.org