You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/01/15 23:50:33 UTC
[GitHub] meisam opened a new pull request #48: [LIVY-41] Let users access
sessions by session name
meisam opened a new pull request #48: [LIVY-41] Let users access sessions by session name
URL: https://github.com/apache/incubator-livy/pull/48
This commit enables Livy users to access sessions either by names or by auto-generated sessiond id's.
It also prevents users from creating sessions that have the same name.
This commit keeps API change minimal. Thse are palces that API change
is needed:
- `Session` and its subclasses adds a new field, `name`.
- `RecoveryMetadata` and its subclasses adds a new field, `name`.
- `SessionManager` adds a new method `getSession(name: String)` which lookups sessions by name.
A more clean implementation would change the signature of `SessionManager.register` so it returns a proper container around the session value to determine if it failed to register the given session. For example,
```Scala
def register(session S): Either[S, Throwable]
```
Task-url: https://issues.apache.org/jira/browse/LIVY-41
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services