You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org> on 2011/06/16 10:15:49 UTC
[jira] [Created] (HADOOP-7399) Remove Writable from ipc.Client and
ipc.Server.
Remove Writable from ipc.Client and ipc.Server.
-----------------------------------------------
Key: HADOOP-7399
URL: https://issues.apache.org/jira/browse/HADOOP-7399
Project: Hadoop Common
Issue Type: Improvement
Reporter: Jitendra Nath Pandey
Assignee: Jitendra Nath Pandey
This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7399) Remove Writable from ipc.Client
and ipc.Server.
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064038#comment-13064038 ]
Suresh Srinivas commented on HADOOP-7399:
-----------------------------------------
Can you please add more detailed description on how the current code is and how this is change improves things.
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7399.3.patch, HADOOP-7399.9.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7399) Remove Writable from ipc.Client and
ipc.Server.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7399:
-----------------------------------------
Status: Patch Available (was: Open)
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7399.3.patch, HADOOP-7399.9.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7399) Remove Writable from ipc.Client
and ipc.Server.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13056229#comment-13056229 ]
Hadoop QA commented on HADOOP-7399:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12484365/HADOOP-7399.9.patch
against trunk revision 1140010.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1078 javac compiler warnings (more than the trunk's current 1067 warnings).
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/678//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/678//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/678//console
This message is automatically generated.
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7399.3.patch, HADOOP-7399.9.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7399) Remove Writable from ipc.Client and
ipc.Server.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7399:
-----------------------------------------
Resolution: Invalid
Status: Resolved (was: Patch Available)
This topic needs to be completely revisited in light of the rpc/protobuf changes.
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.24.0
>
> Attachments: HADOOP-7399.3.patch, HADOOP-7399.9.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7399) Remove Writable from ipc.Client
and ipc.Server.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13051378#comment-13051378 ]
Hadoop QA commented on HADOOP-7399:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12482993/HADOOP-7399.3.patch
against trunk revision 1136249.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 1074 javac compiler warnings (more than the trunk's current 1067 warnings).
-1 findbugs. The patch appears to introduce 3 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/651//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/651//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/651//console
This message is automatically generated.
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7399.3.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7399) Remove Writable from ipc.Client
and ipc.Server.
Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13064057#comment-13064057 ]
Suresh Srinivas commented on HADOOP-7399:
-----------------------------------------
Early comments:
Comments:
# Please add javadoc to ClientCall constructor. Some of the parameters in method javadoc is missing description as well.
# Should ClentCall#responseClass be final? Also should we consider making some of the methods that are not expected to be overridden by subclasses, final?
# Should ClientCall#setException() be called, readException*(). Also is the IOException that is thrown, the exception read from the DataInputStream. If so can you add that to javadoc.
# Since ClientCall has error member, should it also have value member? You could have read
# Please add @Override to methods
# WritableRpcCall#setException() should call ClientCall#setException() instead of duplicating the code.
I will continue to review it.
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7399.3.patch, HADOOP-7399.9.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7399) Remove Writable from ipc.Client and
ipc.Server.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7399:
-----------------------------------------
Fix Version/s: 0.23.0
Status: Patch Available (was: Open)
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7399.3.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7399) Remove Writable from ipc.Client and
ipc.Server.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7399:
-----------------------------------------
Attachment: HADOOP-7399.9.patch
Updated patch, with a little more cleaned up interfaces. The server uses special "calls" for sasl messages as well. I have maintained the same mechanism by adding a SaslServerCall that implements ServerCall. SaslServerCall is not RpcEngine specific and still uses Writable because client assumes a writable format. Encoding of sasl messages could also be delegated to the RpcEngine but I would prefer to do that in a separate jira.
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7399.3.patch, HADOOP-7399.9.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7399) Remove Writable from ipc.Client and
ipc.Server.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7399:
-----------------------------------------
Status: Open (was: Patch Available)
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Fix For: 0.23.0
>
> Attachments: HADOOP-7399.3.patch, HADOOP-7399.9.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7399) Remove Writable from ipc.Client and
ipc.Server.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7399:
-----------------------------------------
Attachment: HADOOP-7399.3.patch
This is a very early version of the patch. I still need to do lot more code cleanup. Sasl messages for connection setup also need to be handled consistently. The basic idea is to use ClientCall and ServerCall as the abstractions for interaction between an RpcEngine and ipc.Client/Server.
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7399.3.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7399) Remove Writable from ipc.Client and
ipc.Server.
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-7399:
-----------------------------------------
Hadoop Flags: [Incompatible change]
> Remove Writable from ipc.Client and ipc.Server.
> -----------------------------------------------
>
> Key: HADOOP-7399
> URL: https://issues.apache.org/jira/browse/HADOOP-7399
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Jitendra Nath Pandey
> Assignee: Jitendra Nath Pandey
> Attachments: HADOOP-7399.3.patch
>
>
> This jira proposes to remove the dependency of ipc client and server on Writable. I think this will be an important step towards making an RpcEngine truly configurable, without having to use tunnel protocols as in case of AvroRPCEngine.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira