You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org> on 2014/03/03 10:48:23 UTC

[jira] [Comment Edited] (HBASE-10531) Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo

    [ https://issues.apache.org/jira/browse/HBASE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917876#comment-13917876 ] 

ramkrishna.s.vasudevan edited comment on HBASE-10531 at 3/3/14 9:47 AM:
------------------------------------------------------------------------

bq.Eventually we should be able to have new implementation of Cell where we just the row/family/column/ts without copying anything (actually that is part of the goal).
Yes Lars.  That is mentioned in my comments.  Currently we need to make a cell and make changes to the code to deal with Cells.  That is why from the available key I made cell(which involves a copy).
To do this we need some changes on some of the places in the code where the keys are getting created.  So we need to change that.

{Edit} : comment re phrased


was (Author: ram_krish):
bq.Eventually we should be able to have new implementation of Cell where we just the row/family/column/ts without copying anything (actually that is part of the goal).
Yes Lars.  That is mentioned in my comments.  Currently we need to make a cell and make changes to the code to deal with Cells.  I can do that change also.

> Revisit how the key byte[] is passed to HFileScanner.seekTo and reseekTo
> ------------------------------------------------------------------------
>
>                 Key: HBASE-10531
>                 URL: https://issues.apache.org/jira/browse/HBASE-10531
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 0.99.0
>
>         Attachments: HBASE-10531.patch, HBASE-10531_1.patch
>
>
> Currently the byte[] key passed to HFileScanner.seekTo and HFileScanner.reseekTo, is a combination of row, cf, qual, type and ts.  And the caller forms this by using kv.getBuffer, which is actually deprecated.  So see how this can be achieved considering kv.getBuffer is removed.



--
This message was sent by Atlassian JIRA
(v6.2#6252)