You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/02 14:36:27 UTC

[GitHub] [iotdb] neuyilan commented on a diff in pull request #8265: [IOTDB-5091] add space quota: device and timeseries num limit

neuyilan commented on code in PR #8265:
URL: https://github.com/apache/iotdb/pull/8265#discussion_r1038204756


##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/ClusterQuotaManager.java:
##########
@@ -46,10 +49,16 @@ public class ClusterQuotaManager {
 
   private final IManager configManager;
   private final QuotaInfo quotaInfo;
+  private final Map<Integer, Integer> deviceNum;
+  private final Map<Integer, Integer> timeSeriesNum;

Review Comment:
   It better uses a concurrent map, it will be updated concurrently during a heartbeat（because the callback thread may run concurrently.）.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org