You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/03/18 15:12:14 UTC
[GitHub] [couchdb] bessbd opened a new pull request #3439: Remove CentOS 6 from CI
bessbd opened a new pull request #3439:
URL: https://github.com/apache/couchdb/pull/3439
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
According to https://wiki.centos.org/FAQ/General#What_is_the_support_.27.27end_of_life.27.27_for_each_CentOS_release.3F CentOS 6 is now discontinued. This PR removes it from the matrix.
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3439: Remove CentOS 6 from CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3439:
URL: https://github.com/apache/couchdb/pull/3439#issuecomment-802282936
Thank you for the review, @nickva , @rnewson , @janl and @wohali !
I'll merge this tomorrow and add extra info on the motivation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3439: Remove CentOS 6 from CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3439:
URL: https://github.com/apache/couchdb/pull/3439#issuecomment-802030788
> +1 from me but would like @wohali or @janl to comment also before we merge.
I'll wait for @wohali or @janl 's +1 then before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] janl commented on pull request #3439: Remove CentOS 6 from CI
Posted by GitBox <gi...@apache.org>.
janl commented on pull request #3439:
URL: https://github.com/apache/couchdb/pull/3439#issuecomment-802210259
I'm generally +1, but would also defer to @wohali for a final call :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3439: Remove CentOS 6 from CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3439:
URL: https://github.com/apache/couchdb/pull/3439#issuecomment-802805857
Motivation: as I was working on #3394 to get a green `main`, I was looking at the broken https://github.com/apache/couchdb/blob/main/src/mango/test/17-multi-type-value-test.py#L28 and I've noticed it's green everywhere but centos6.
I fired up the centos6 image in docker and realized couchdb `main` always returns one row less there than in my native (osx) environment.
After a long tracing and debugging session (with plenty of help from @nickva - thanks for that!), we've discovered that
`couch_ejson_compare:less([{[{<<"forename">>,<<"Eddie">>}]}], [{[{<<"ÿÿÿÿ">>,<<>>}]}]).` always returns `1` on centos6 and `-1` elswehere.
When I was trying to bump the libicu version, I've noticed the `yum` commands are failing so I looked up the supported centos versions and that's when I realized it's now discontinued - hence this PR.
@wohali : please let me know if I missed any important details here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on pull request #3439: Remove CentOS 6 from CI
Posted by GitBox <gi...@apache.org>.
nickva commented on pull request #3439:
URL: https://github.com/apache/couchdb/pull/3439#issuecomment-802300378
@bessbd nice work discovering the bug, it was a rather tricky one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd merged pull request #3439: Remove CentOS 6 from CI
Posted by GitBox <gi...@apache.org>.
bessbd merged pull request #3439:
URL: https://github.com/apache/couchdb/pull/3439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org