[GitHub] [calcite] danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #1157: [CALCITE-2969] Improve design of join-like relational expressions
URL: https://github.com/apache/calcite/pull/1157#discussion_r276496556
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableThetaJoin.java
 ##########
 @@ -45,6 +46,7 @@
 /** Implementation of {@link org.apache.calcite.rel.core.Join} in
  * {@link org.apache.calcite.adapter.enumerable.EnumerableConvention enumerable calling convention}
  * that allows conditions that are not just {@code =} (equals). */
+@Deprecated // to be removed before 2.0
 
 Review comment:
   Theta join can be implement through other like join, e.g. NestedLoopJoin, i want to refactor it also, but not in this patch, i agree to remove the annotation now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services