You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sid Wagle <sw...@hortonworks.com> on 2014/04/15 02:20:39 UTC
Review Request 20346: Stack definition does not provide global properties
with empty values
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/
-----------------------------------------------------------
Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-5387
https://issues.apache.org/jira/browse/AMBARI-5387
Repository: ambari
Description
-------
In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
The specific property was HBase's {{hregion_memstoreflushsize}}.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
ambari-web/app/data/HDP2/site_properties.js dedd4ca
ambari-web/app/utils/helper.js 1335ff2
ambari-web/app/views/common/configs/services_config.js 8143711
Diff: https://reviews.apache.org/r/20346/diff/
Testing
-------
Thanks,
Sid Wagle
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40686
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
<https://reviews.apache.org/r/20346/#comment73788>
I still don't like this. In my opinion a property with a null or empty name is an error which should be reported to the user and shouldn't be swallowed.
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml
<https://reviews.apache.org/r/20346/#comment73762>
just making sure about this. In the past I know that ambari UI would set the value "60010" for this property.
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml
<https://reviews.apache.org/r/20346/#comment73764>
Are we sure this is ok to remove? I seem to remember that we had to set the value to a space character ' ' in the past.
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml
<https://reviews.apache.org/r/20346/#comment73766>
same as the above comment
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml
<https://reviews.apache.org/r/20346/#comment73777>
this is the same description as the hive_database_name property
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml
<https://reviews.apache.org/r/20346/#comment73780>
shouldn't we specify a default database name?
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml
<https://reviews.apache.org/r/20346/#comment73773>
typo
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml
<https://reviews.apache.org/r/20346/#comment73782>
same comment as matching property in v1.3.2 stack
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml
<https://reviews.apache.org/r/20346/#comment73783>
same comment as matching property in v1.3.2 stack
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
<https://reviews.apache.org/r/20346/#comment73785>
same as other whitelist property comments
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
<https://reviews.apache.org/r/20346/#comment73786>
same as other whitelist property comments
- John Speidel
On April 16, 2014, 10:30 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 16, 2014, 10:30 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8
> ambari-web/app/data/HDP2/site_properties.js 8c0ac63
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40711
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml
<https://reviews.apache.org/r/20346/#comment73831>
Typo. m in COm is lowercase.
- Yusaku Sako
On April 17, 2014, 10:49 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 17, 2014, 10:49 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 98bc4e8
> ambari-web/app/data/HDP2/site_properties.js 8c0ac63
> ambari-web/app/data/site_properties.js 35c6404
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40730
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml
<https://reviews.apache.org/r/20346/#comment73873>
I didn't see a response for my earlier comment that we should provide a default database name here
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml
<https://reviews.apache.org/r/20346/#comment73874>
I didn't see a response to my earlier comment about adding a default database name here.
- John Speidel
On April 18, 2014, 12:03 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 12:03 a.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 98bc4e8
> ambari-web/app/data/HDP2/site_properties.js 8c0ac63
> ambari-web/app/data/site_properties.js 35c6404
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Siddharth Wagle <sw...@hortonworks.com>.
I attached a file with just that change, so I probably shows up
differently. Did not make updates to existing patch.
On Fri, Apr 18, 2014 at 6:40 AM, John Speidel <js...@hortonworks.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
>
> Ship it!
>
> Odd, the last patch that you posted doesn't include earlier changes and shows up differently in the review.
> +1, assuming that functional tests have passed with these changes.
>
>
> - John Speidel
>
> On April 18th, 2014, 5:27 a.m. UTC, Sid Wagle wrote:
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
> By Sid Wagle.
>
> *Updated April 18, 2014, 5:27 a.m.*
> *Bugs: * AMBARI-5387 <https://issues.apache.org/jira/browse/AMBARI-5387>
> *Repository: * ambari
> Description
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
> Testing
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
> Diffs
>
> - ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
> (52c7309)
> - ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
> (c31d437)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml
> (453184b)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml
> (bd4d61f)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml
> (d2bff0f)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml
> (04d51db)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml
> (900da99)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml
> (9c28bec)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml
> (ae7f586)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml
> (34e6231)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml
> (4633855)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml
> (7255ca3)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml
> (ddbf780)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml
> (f4d4b63)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml
> (16d8691)
> - ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml
> (f78df89)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml
> (b2c57bd)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml
> (cf9416e)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml
> (ffda6e2)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml
> (d7b37c4)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml
> (ae7f586)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml
> (1e4ba38)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml
> (ddbf780)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml
> (f96e562)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml
> (5b5115a)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml
> (984cd41)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml
> (310095f)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml
> (c3a37ef)
> - ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml
> (f78df89)
> - ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml
> (9746e24)
> - ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml
> (e1e3812)
> - ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml
> (f320b23)
> - ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml
> (130004a)
> - ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml
> (9c748da)
> - ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
> (8c0bd65)
> - ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java
> (2f17c52)
> - ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
> (98bc4e8)
> - ambari-web/app/data/HDP2/site_properties.js (8c0ac63)
> - ambari-web/app/data/site_properties.js (35c6404)
> - ambari-web/app/utils/helper.js (1335ff2)
> - ambari-web/app/views/common/configs/services_config.js (8143711)
>
> View Diff <https://reviews.apache.org/r/20346/diff/>
> File Attachments
>
> - Fix for hive_database_name.<https://reviews.apache.org/media/uploaded/files/2014/04/18/1bd3ebae-46db-4595-9810-51f6b3e593b8__AMBARI-5387-2.patch>
>
>
--
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to
which it is addressed and may contain information that is confidential,
privileged and exempt from disclosure under applicable law. If the reader
of this message is not the intended recipient, you are hereby notified that
any printing, copying, dissemination, distribution, disclosure or
forwarding of this communication is strictly prohibited. If you have
received this communication in error, please contact the sender immediately
and delete it from your system. Thank You.
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40769
-----------------------------------------------------------
Ship it!
Odd, the last patch that you posted doesn't include earlier changes and shows up differently in the review.
+1, assuming that functional tests have passed with these changes.
- John Speidel
On April 18, 2014, 5:27 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 18, 2014, 5:27 a.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 98bc4e8
> ambari-web/app/data/HDP2/site_properties.js 8c0ac63
> ambari-web/app/data/site_properties.js 35c6404
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> File Attachments
> ----------------
>
> Fix for hive_database_name.
> https://reviews.apache.org/media/uploaded/files/2014/04/18/1bd3ebae-46db-4595-9810-51f6b3e593b8__AMBARI-5387-2.patch
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/
-----------------------------------------------------------
(Updated April 18, 2014, 5:27 a.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
Changes
-------
Incorporated comments for hive_database_name property.
Bugs: AMBARI-5387
https://issues.apache.org/jira/browse/AMBARI-5387
Repository: ambari
Description
-------
In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
The specific property was HBase's {{hregion_memstoreflushsize}}.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 98bc4e8
ambari-web/app/data/HDP2/site_properties.js 8c0ac63
ambari-web/app/data/site_properties.js 35c6404
ambari-web/app/utils/helper.js 1335ff2
ambari-web/app/views/common/configs/services_config.js 8143711
Diff: https://reviews.apache.org/r/20346/diff/
Testing
-------
mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.903s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
[INFO] Ambari Web ........................................ SUCCESS [9.738s]
[INFO] Ambari Views ...................................... SUCCESS [1.824s]
[INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
[INFO] Ambari Agent ...................................... SUCCESS [15.514s]
[INFO] Ambari Client ..................................... SUCCESS [0.529s]
[INFO] ------------------------------------------------------------------------
File Attachments (updated)
----------------
Fix for hive_database_name.
https://reviews.apache.org/media/uploaded/files/2014/04/18/1bd3ebae-46db-4595-9810-51f6b3e593b8__AMBARI-5387-2.patch
Thanks,
Sid Wagle
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/
-----------------------------------------------------------
(Updated April 18, 2014, 12:03 a.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-5387
https://issues.apache.org/jira/browse/AMBARI-5387
Repository: ambari
Description
-------
In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
The specific property was HBase's {{hregion_memstoreflushsize}}.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 98bc4e8
ambari-web/app/data/HDP2/site_properties.js 8c0ac63
ambari-web/app/data/site_properties.js 35c6404
ambari-web/app/utils/helper.js 1335ff2
ambari-web/app/views/common/configs/services_config.js 8143711
Diff: https://reviews.apache.org/r/20346/diff/
Testing
-------
mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.903s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
[INFO] Ambari Web ........................................ SUCCESS [9.738s]
[INFO] Ambari Views ...................................... SUCCESS [1.824s]
[INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
[INFO] Ambari Agent ...................................... SUCCESS [15.514s]
[INFO] Ambari Client ..................................... SUCCESS [0.529s]
[INFO] ------------------------------------------------------------------------
Thanks,
Sid Wagle
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/
-----------------------------------------------------------
(Updated April 17, 2014, 11:40 p.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
Changes
-------
Fixed typo.
Bugs: AMBARI-5387
https://issues.apache.org/jira/browse/AMBARI-5387
Repository: ambari
Description
-------
In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
The specific property was HBase's {{hregion_memstoreflushsize}}.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 98bc4e8
ambari-web/app/data/HDP2/site_properties.js 8c0ac63
ambari-web/app/data/site_properties.js 35c6404
ambari-web/app/utils/helper.js 1335ff2
ambari-web/app/views/common/configs/services_config.js 8143711
Diff: https://reviews.apache.org/r/20346/diff/
Testing
-------
mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.903s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
[INFO] Ambari Web ........................................ SUCCESS [9.738s]
[INFO] Ambari Views ...................................... SUCCESS [1.824s]
[INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
[INFO] Ambari Agent ...................................... SUCCESS [15.514s]
[INFO] Ambari Client ..................................... SUCCESS [0.529s]
[INFO] ------------------------------------------------------------------------
File Attachments (updated)
----------------
Fixed typo
https://reviews.apache.org/media/uploaded/files/2014/04/17/1794ed63-4fcd-45cc-ad9f-5813fd9759ee__AMBARI-5387-1.patch
Thanks,
Sid Wagle
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/
-----------------------------------------------------------
(Updated April 17, 2014, 10:49 p.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
Changes
-------
Addressed all of the comments except adding "blacklist" and "whilelist" properties back into the stack definition since these properties do not always have empty as valid values and there is no correct default value.
Verified deploying a cluster works for HDP-1.3.3, HDP-2.0 and HDP-2.1 thorough the UI with these changes.
Bugs: AMBARI-5387
https://issues.apache.org/jira/browse/AMBARI-5387
Repository: ambari
Description
-------
In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
The specific property was HBase's {{hregion_memstoreflushsize}}.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 98bc4e8
ambari-web/app/data/HDP2/site_properties.js 8c0ac63
ambari-web/app/data/site_properties.js 35c6404
ambari-web/app/utils/helper.js 1335ff2
ambari-web/app/views/common/configs/services_config.js 8143711
Diff: https://reviews.apache.org/r/20346/diff/
Testing
-------
mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.903s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
[INFO] Ambari Web ........................................ SUCCESS [9.738s]
[INFO] Ambari Views ...................................... SUCCESS [1.824s]
[INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
[INFO] Ambari Agent ...................................... SUCCESS [15.514s]
[INFO] Ambari Client ..................................... SUCCESS [0.529s]
[INFO] ------------------------------------------------------------------------
Thanks,
Sid Wagle
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/
-----------------------------------------------------------
(Updated April 16, 2014, 10:30 p.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
Changes
-------
Added properties back which have valid default values.
"Ideally, the stack definition would be self contained meaning that it contains all default configurations (where possible)."
Paradigm to delete properties:
- Unless the component-site.default.xml has the value there is no reason we should have it in Ambari stack.
- If the property is in the site default and a purely optional property that can only be set by users, example: yarn.app.mapreduce.am.env
Bugs: AMBARI-5387
https://issues.apache.org/jira/browse/AMBARI-5387
Repository: ambari
Description
-------
In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
The specific property was HBase's {{hregion_memstoreflushsize}}.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8
ambari-web/app/data/HDP2/site_properties.js 8c0ac63
ambari-web/app/utils/helper.js 1335ff2
ambari-web/app/views/common/configs/services_config.js 8143711
Diff: https://reviews.apache.org/r/20346/diff/
Testing
-------
mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.903s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
[INFO] Ambari Web ........................................ SUCCESS [9.738s]
[INFO] Ambari Views ...................................... SUCCESS [1.824s]
[INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
[INFO] Ambari Agent ...................................... SUCCESS [15.514s]
[INFO] Ambari Client ..................................... SUCCESS [0.529s]
[INFO] ------------------------------------------------------------------------
Thanks,
Sid Wagle
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/
-----------------------------------------------------------
(Updated April 15, 2014, 7:35 p.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-5387
https://issues.apache.org/jira/browse/AMBARI-5387
Repository: ambari
Description
-------
In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
The specific property was HBase's {{hregion_memstoreflushsize}}.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8
ambari-web/app/data/HDP2/site_properties.js 3e1c230
ambari-web/app/utils/helper.js 1335ff2
ambari-web/app/views/common/configs/services_config.js 8143711
Diff: https://reviews.apache.org/r/20346/diff/
Testing
-------
mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.903s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
[INFO] Ambari Web ........................................ SUCCESS [9.738s]
[INFO] Ambari Views ...................................... SUCCESS [1.824s]
[INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
[INFO] Ambari Agent ...................................... SUCCESS [15.514s]
[INFO] Ambari Client ..................................... SUCCESS [0.529s]
[INFO] ------------------------------------------------------------------------
Thanks,
Sid Wagle
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml, lines 25-34
> > <https://reviews.apache.org/r/20346/diff/1/?file=557722#file557722line25>
> >
> > Why are we deleting properties which previously existed but had no values? Are these properties no longer used? This comment applies to all properties which were removed across all of the diffs.
> >
> > There are some deleted properties which seem that they are still used and would have valid default values such as hbase.master.info.port ...
> >
> >
>
> Sid Wagle wrote:
> The deleted properties are of the form "_host(s)". These are used to convey cluster topology info to the agent. The server sends these without looking at the stack properties so these were pretty much placeholder with current code.
>
> Another point is, if someone wants to add a Service we cannot rely on topology related properties to be present in the global config of a new service definition.
>
> I have opened a new Jira for standardizing on the way topology info is sent, basically something like, componentName_category_host(s).
>
> John Speidel wrote:
> ok. But why would be delete properties such as hbase-site/hbase.master.info.port?
The properties deleted like "hbase.master.info.port" were not set by the UI while saving configs. This is an optional override that the user can provide if needed. I had the option of either providing a value corresponding to what is checked into HBase trunk or remove the property which would represent what happens with a default cluster install. Note: If I do not remove the property and leave it as empty the UI code needs to handle the property, by making it not required, or setting a value. None of these property have empty as valid default.
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40418
-----------------------------------------------------------
On April 15, 2014, 7:35 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 7:35 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8
> ambari-web/app/data/HDP2/site_properties.js 3e1c230
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > There are still many props with empty values in stack definition which haven't been updated.
> > For example, 2.0.5/services/HBASE/configuration/hbase-site.xml/hbase.tmp.dir. This property was just randomly picked from the list.
> >
> > Are there no valid defaults for these properties?
Addressed only the stacks that can be deployed with 1.5.0, in this patch.
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java, line 597
> > <https://reviews.apache.org/r/20346/diff/1/?file=557721#file557721line597>
> >
> > Why would the property name be null or empty? Was there an issue which prompted adding this check?
Correct, there was empty property and it resulted in an UI issue.
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java, line 604
> > <https://reviews.apache.org/r/20346/diff/1/?file=557721#file557721line604>
> >
> > It is not clear to me what this log msg means.
This needs to be scratched out, thanks for pointing out.
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml, lines 25-34
> > <https://reviews.apache.org/r/20346/diff/1/?file=557722#file557722line25>
> >
> > Why are we deleting properties which previously existed but had no values? Are these properties no longer used? This comment applies to all properties which were removed across all of the diffs.
> >
> > There are some deleted properties which seem that they are still used and would have valid default values such as hbase.master.info.port ...
> >
> >
The deleted properties are of the form "_host(s)". These are used to convey cluster topology info to the agent. The server sends these without looking at the stack properties so these were pretty much placeholder with current code.
Another point is, if someone wants to add a Service we cannot rely on topology related properties to be present in the global config of a new service definition.
I have opened a new Jira for standardizing on the way topology info is sent, basically something like, componentName_category_host(s).
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40418
-----------------------------------------------------------
On April 15, 2014, 1:09 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 1:09 a.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-web/app/data/HDP2/site_properties.js dedd4ca
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by John Speidel <js...@hortonworks.com>.
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java, line 597
> > <https://reviews.apache.org/r/20346/diff/1/?file=557721#file557721line597>
> >
> > Why would the property name be null or empty? Was there an issue which prompted adding this check?
>
> Sid Wagle wrote:
> Correct, there was empty property and it resulted in an UI issue.
Wouldn't it be better to remove the offending property from the stack? How is a property with no name useful?
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml, lines 25-34
> > <https://reviews.apache.org/r/20346/diff/1/?file=557722#file557722line25>
> >
> > Why are we deleting properties which previously existed but had no values? Are these properties no longer used? This comment applies to all properties which were removed across all of the diffs.
> >
> > There are some deleted properties which seem that they are still used and would have valid default values such as hbase.master.info.port ...
> >
> >
>
> Sid Wagle wrote:
> The deleted properties are of the form "_host(s)". These are used to convey cluster topology info to the agent. The server sends these without looking at the stack properties so these were pretty much placeholder with current code.
>
> Another point is, if someone wants to add a Service we cannot rely on topology related properties to be present in the global config of a new service definition.
>
> I have opened a new Jira for standardizing on the way topology info is sent, basically something like, componentName_category_host(s).
ok. But why would be delete properties such as hbase-site/hbase.master.info.port?
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40418
-----------------------------------------------------------
On April 15, 2014, 7:35 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 7:35 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8
> ambari-web/app/data/HDP2/site_properties.js 3e1c230
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java, line 597
> > <https://reviews.apache.org/r/20346/diff/1/?file=557721#file557721line597>
> >
> > Why would the property name be null or empty? Was there an issue which prompted adding this check?
>
> Sid Wagle wrote:
> Correct, there was empty property and it resulted in an UI issue.
>
> John Speidel wrote:
> Wouldn't it be better to remove the offending property from the stack? How is a property with no name useful?
Done that as well, this is added as blanket check.
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml, lines 25-34
> > <https://reviews.apache.org/r/20346/diff/1/?file=557722#file557722line25>
> >
> > Why are we deleting properties which previously existed but had no values? Are these properties no longer used? This comment applies to all properties which were removed across all of the diffs.
> >
> > There are some deleted properties which seem that they are still used and would have valid default values such as hbase.master.info.port ...
> >
> >
>
> Sid Wagle wrote:
> The deleted properties are of the form "_host(s)". These are used to convey cluster topology info to the agent. The server sends these without looking at the stack properties so these were pretty much placeholder with current code.
>
> Another point is, if someone wants to add a Service we cannot rely on topology related properties to be present in the global config of a new service definition.
>
> I have opened a new Jira for standardizing on the way topology info is sent, basically something like, componentName_category_host(s).
>
> John Speidel wrote:
> ok. But why would be delete properties such as hbase-site/hbase.master.info.port?
>
> Sid Wagle wrote:
> The properties deleted like "hbase.master.info.port" were not set by the UI while saving configs. This is an optional override that the user can provide if needed. I had the option of either providing a value corresponding to what is checked into HBase trunk or remove the property which would represent what happens with a default cluster install. Note: If I do not remove the property and leave it as empty the UI code needs to handle the property, by making it not required, or setting a value. None of these property have empty as valid default.
>
> John Speidel wrote:
> I think that it is important to include these properties in the stack with default values which are appropriate for the corresponding service version. This way a user can use the api to determine the current value. This is very important for Sahara(Savanna) because it makes this information available to the user. Ideally, the stack definition would be self contained meaning that it contains all default configurations (where possible).
Ok, I will add these back with default values.
- Sid
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40418
-----------------------------------------------------------
On April 15, 2014, 7:35 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 7:35 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8
> ambari-web/app/data/HDP2/site_properties.js 3e1c230
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by John Speidel <js...@hortonworks.com>.
> On April 15, 2014, 6:30 p.m., John Speidel wrote:
> > ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml, lines 25-34
> > <https://reviews.apache.org/r/20346/diff/1/?file=557722#file557722line25>
> >
> > Why are we deleting properties which previously existed but had no values? Are these properties no longer used? This comment applies to all properties which were removed across all of the diffs.
> >
> > There are some deleted properties which seem that they are still used and would have valid default values such as hbase.master.info.port ...
> >
> >
>
> Sid Wagle wrote:
> The deleted properties are of the form "_host(s)". These are used to convey cluster topology info to the agent. The server sends these without looking at the stack properties so these were pretty much placeholder with current code.
>
> Another point is, if someone wants to add a Service we cannot rely on topology related properties to be present in the global config of a new service definition.
>
> I have opened a new Jira for standardizing on the way topology info is sent, basically something like, componentName_category_host(s).
>
> John Speidel wrote:
> ok. But why would be delete properties such as hbase-site/hbase.master.info.port?
>
> Sid Wagle wrote:
> The properties deleted like "hbase.master.info.port" were not set by the UI while saving configs. This is an optional override that the user can provide if needed. I had the option of either providing a value corresponding to what is checked into HBase trunk or remove the property which would represent what happens with a default cluster install. Note: If I do not remove the property and leave it as empty the UI code needs to handle the property, by making it not required, or setting a value. None of these property have empty as valid default.
I think that it is important to include these properties in the stack with default values which are appropriate for the corresponding service version. This way a user can use the api to determine the current value. This is very important for Sahara(Savanna) because it makes this information available to the user. Ideally, the stack definition would be self contained meaning that it contains all default configurations (where possible).
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40418
-----------------------------------------------------------
On April 15, 2014, 7:35 p.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 7:35 p.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-server/src/test/java/org/apache/ambari/server/api/util/StackExtensionHelperTest.java 2f17c52
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java 73530a8
> ambari-web/app/data/HDP2/site_properties.js 3e1c230
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/#review40418
-----------------------------------------------------------
There are still many props with empty values in stack definition which haven't been updated.
For example, 2.0.5/services/HBASE/configuration/hbase-site.xml/hbase.tmp.dir. This property was just randomly picked from the list.
Are there no valid defaults for these properties?
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
<https://reviews.apache.org/r/20346/#comment73405>
Why would the property name be null or empty? Was there an issue which prompted adding this check?
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java
<https://reviews.apache.org/r/20346/#comment73407>
It is not clear to me what this log msg means.
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml
<https://reviews.apache.org/r/20346/#comment73415>
Why are we deleting properties which previously existed but had no values? Are these properties no longer used? This comment applies to all properties which were removed across all of the diffs.
There are some deleted properties which seem that they are still used and would have valid default values such as hbase.master.info.port ...
- John Speidel
On April 15, 2014, 1:09 a.m., Sid Wagle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20346/
> -----------------------------------------------------------
>
> (Updated April 15, 2014, 1:09 a.m.)
>
>
> Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
>
>
> Bugs: AMBARI-5387
> https://issues.apache.org/jira/browse/AMBARI-5387
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
>
> The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
>
> http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
>
>
> The specific property was HBase's {{hregion_memstoreflushsize}}.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
> ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
> ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
> ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
> ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
> ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
> ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
> ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
> ambari-web/app/data/HDP2/site_properties.js dedd4ca
> ambari-web/app/utils/helper.js 1335ff2
> ambari-web/app/views/common/configs/services_config.js 8143711
>
> Diff: https://reviews.apache.org/r/20346/diff/
>
>
> Testing
> -------
>
> mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [1.903s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
> [INFO] Ambari Web ........................................ SUCCESS [9.738s]
> [INFO] Ambari Views ...................................... SUCCESS [1.824s]
> [INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
> [INFO] Ambari Agent ...................................... SUCCESS [15.514s]
> [INFO] Ambari Client ..................................... SUCCESS [0.529s]
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sid Wagle
>
>
Re: Review Request 20346: Stack definition does not provide global
properties with empty values
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20346/
-----------------------------------------------------------
(Updated April 15, 2014, 1:09 a.m.)
Review request for Ambari, John Speidel, Sumit Mohanty, and Yusaku Sako.
Bugs: AMBARI-5387
https://issues.apache.org/jira/browse/AMBARI-5387
Repository: ambari
Description
-------
In host overrides we depend on properties defined in {{global.xml}} to determine which service needs to be restarted when properties are changed.
The stack definition API we call however does not provide properties with empty values in {{global.xml}}. This effects UI because we do not show a service restart required when necessary.
http://server:8080/api/v1/stacks2/HDP/versions/2.0.6/stackServices?fields=configurations/StackConfigurations/type
The specific property was HBase's {{hregion_memstoreflushsize}}.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java 52c7309
ambari-server/src/main/java/org/apache/ambari/server/api/util/StackExtensionHelper.java c31d437
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/global.xml 453184b
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HBASE/configuration/hbase-site.xml bd4d61f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/core-site.xml d2bff0f
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/global.xml 04d51db
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hadoop-policy.xml 900da99
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HDFS/configuration/hdfs-site.xml 9c28bec
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/HIVE/configuration/hive-site.xml 34e6231
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/global.xml 4633855
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/MAPREDUCE/configuration/mapred-site.xml 7255ca3
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/OOZIE/configuration/oozie-site.xml f4d4b63
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/WEBHCAT/configuration/webhcat-site.xml 16d8691
ambari-server/src/main/resources/stacks/HDP/1.3.2/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/global.xml b2c57bd
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/configuration/hbase-site.xml cf9416e
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/global.xml ffda6e2
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HDFS/configuration/hdfs-site.xml d7b37c4
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/global.xml ae7f586
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HIVE/configuration/hive-site.xml 1e4ba38
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/global.xml ddbf780
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/OOZIE/configuration/oozie-site.xml f96e562
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/WEBHCAT/configuration/webhcat-site.xml 5b5115a
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/global.xml 984cd41
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration-mapred/mapred-site.xml 310095f
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/YARN/configuration/global.xml c3a37ef
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/ZOOKEEPER/configuration/global.xml f78df89
ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/configuration/falcon-startup.properties.xml 9746e24
ambari-server/src/main/resources/stacks/HDP/2.1/services/HIVE/configuration/hive-site.xml e1e3812
ambari-server/src/main/resources/stacks/HDP/2.1/services/OOZIE/configuration/oozie-site.xml f320b23
ambari-server/src/main/resources/stacks/HDP/2.1/services/WEBHCAT/configuration/webhcat-site.xml 130004a
ambari-server/src/main/resources/stacks/HDP/2.1/services/YARN/configuration/global.xml 9c748da
ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java 8c0bd65
ambari-web/app/data/HDP2/site_properties.js dedd4ca
ambari-web/app/utils/helper.js 1335ff2
ambari-web/app/views/common/configs/services_config.js 8143711
Diff: https://reviews.apache.org/r/20346/diff/
Testing (updated)
-------
mvn clean test -Djava.awt.headless=true -DfailIfNoTests=false
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [1.903s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.301s]
[INFO] Ambari Web ........................................ SUCCESS [9.738s]
[INFO] Ambari Views ...................................... SUCCESS [1.824s]
[INFO] Ambari Server ..................................... SUCCESS [14:19.226s]
[INFO] Ambari Agent ...................................... SUCCESS [15.514s]
[INFO] Ambari Client ..................................... SUCCESS [0.529s]
[INFO] ------------------------------------------------------------------------
Thanks,
Sid Wagle