You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/21 02:11:53 UTC
[GitHub] [airflow] Bowrna opened a new pull request, #27173: fixing the typing for session with Optional typing
Bowrna opened a new pull request, #27173:
URL: https://github.com/apache/airflow/pull/27173
Updating the Typing for `Session` in Airflow Listener `spec.py` with `Optional`
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna closed pull request #27173: fixing the typing for session with Optional typing
Posted by GitBox <gi...@apache.org>.
Bowrna closed pull request #27173: fixing the typing for session with Optional typing
URL: https://github.com/apache/airflow/pull/27173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #27173: fixing the typing for session with Optional typing
Posted by GitBox <gi...@apache.org>.
Bowrna commented on PR #27173:
URL: https://github.com/apache/airflow/pull/27173#issuecomment-1286668598
oops. thanks for letting me know @eladkal I will fix it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #27173: fixing the typing for session with Optional typing
Posted by GitBox <gi...@apache.org>.
Bowrna commented on PR #27173:
URL: https://github.com/apache/airflow/pull/27173#issuecomment-1287053644
@eladkal I am trying to replace the typing for `session` param from `Session | None` to `Optional[Session]`
But when I run the static checks it is getting overwritten to the existing format as it fails in `pyupgrade` due to the PEP support for `Session | None` as mentioned here https://github.com/asottile/pyupgrade#pep-604-typing-rewrites
I will close this issue as it's not a valid PR for this reason.
<img width="798" alt="Screenshot 2022-10-21 at 7 55 20 PM" src="https://user-images.githubusercontent.com/10162465/197219954-9ebad682-9c61-42e2-9253-1f9e5a3a7297.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #27173: fixing the typing for session with Optional typing
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #27173:
URL: https://github.com/apache/airflow/pull/27173#issuecomment-1286662000
The commit contains 0 files changed.. something is missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org