You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Branislav Cogic <b....@levi9.com> on 2016/02/17 11:49:41 UTC

Review Request 43648: SAMZA-872: removed unsafe log4j DaillyRollingFileAppender from hello-samza

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43648/
-----------------------------------------------------------

Review request for samza.


Repository: samza-hello-samza


Description
-------

Changed log4j configuration in hello-samza project to reference RolingFileAppender instead of DailyRollingFileAppender


Diffs
-----

  src/main/resources/log4j.xml f0de7658c76fe1b3925b0d73dd3236ff8a297590 

Diff: https://reviews.apache.org/r/43648/diff/


Testing
-------


Thanks,

Branislav Cogic

Re: Review Request 43648: SAMZA-872: removed unsafe log4j DaillyRollingFileAppender from hello-samza

Posted by Jagadish Venkatraman <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43648/#review119633
-----------------------------------------------------------


Ship it!




Ship It!

- Jagadish Venkatraman


On Feb. 17, 2016, 11:01 a.m., Branislav Cogic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43648/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 11:01 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-872
>     https://issues.apache.org/jira/browse/SAMZA-872
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> Changed log4j configuration in hello-samza project to reference RolingFileAppender instead of DailyRollingFileAppender
> 
> 
> Diffs
> -----
> 
>   src/main/resources/log4j.xml f0de7658c76fe1b3925b0d73dd3236ff8a297590 
> 
> Diff: https://reviews.apache.org/r/43648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Branislav Cogic
> 
>

Re: Review Request 43648: SAMZA-872: removed unsafe log4j DaillyRollingFileAppender from hello-samza

Posted by Boris Shkolnik <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43648/#review119545
-----------------------------------------------------------


Ship it!




Ship It!

- Boris Shkolnik


On Feb. 17, 2016, 11:01 a.m., Branislav Cogic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43648/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2016, 11:01 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Bugs: SAMZA-872
>     https://issues.apache.org/jira/browse/SAMZA-872
> 
> 
> Repository: samza-hello-samza
> 
> 
> Description
> -------
> 
> Changed log4j configuration in hello-samza project to reference RolingFileAppender instead of DailyRollingFileAppender
> 
> 
> Diffs
> -----
> 
>   src/main/resources/log4j.xml f0de7658c76fe1b3925b0d73dd3236ff8a297590 
> 
> Diff: https://reviews.apache.org/r/43648/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Branislav Cogic
> 
>

Re: Review Request 43648: SAMZA-872: removed unsafe log4j DaillyRollingFileAppender from hello-samza

Posted by Branislav Cogic <b....@levi9.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43648/
-----------------------------------------------------------

(Updated Feb. 17, 2016, 11:01 a.m.)


Review request for samza.


Bugs: SAMZA-872
    https://issues.apache.org/jira/browse/SAMZA-872


Repository: samza-hello-samza


Description
-------

Changed log4j configuration in hello-samza project to reference RolingFileAppender instead of DailyRollingFileAppender


Diffs
-----

  src/main/resources/log4j.xml f0de7658c76fe1b3925b0d73dd3236ff8a297590 

Diff: https://reviews.apache.org/r/43648/diff/


Testing
-------


Thanks,

Branislav Cogic